You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by sl...@apache.org on 2026/08/19 04:25:43 UTC
(maven-wagon) 01/02: Correct the TCK documentation and remove the unbuilt sample consumer
This is an automated email from the ASF dual-hosted git repository.
slachiewicz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-wagon.git
commit 75501bfb4b8f62fafee04e5bc62a6c63395b3694
Author: Sylwester Lachiewicz <sl...@apache.org>
AuthorDate: Tue Aug 18 22:12:41 2026 +0200
Correct the TCK documentation and remove the unbuilt sample consumer
The sample consumer is not a reactor module and nothing references it, so it has
never been compiled against the TCK it demonstrates.
---
src/site/markdown/developer-guide.md | 14 +++--
.../wagon-tck-http/sample-tck-consumer/pom.xml | 66 ----------------------
.../maven/wagon/tck/http/consumer/TestSuite.java | 31 ----------
.../test/resources/META-INF/plexus/components.xml | 32 -----------
.../META-INF/wagon-tck/http-use-cases.xml | 26 ---------
5 files changed, 8 insertions(+), 161 deletions(-)
diff --git a/src/site/markdown/developer-guide.md b/src/site/markdown/developer-guide.md
index b9f2c685..93fe7dd7 100644
--- a/src/site/markdown/developer-guide.md
+++ b/src/site/markdown/developer-guide.md
@@ -325,7 +325,7 @@ reason phrase the way `HttpMessageUtils` formats them.
## The HTTP TCK
-`wagon-tcks/wagon-tck-http` is a separate, JUnit 4 suite that tests *behaviour* rather
+`wagon-tcks/wagon-tck-http` is a separate JUnit 5 suite that tests *behaviour* rather
than mechanics: what a provider does about redirects, latency, timeouts, missing
hosts and authentication. Unlike `wagon-provider-test`, a provider can declare
individual use cases unsupported rather than failing them.
@@ -363,12 +363,14 @@ individual use cases unsupported rather than failing them.
### Wiring the TCK into a provider
-Add `wagon-tck-http` at test scope, declare a suite, and configure the
-`WagonTestCaseConfigurator` component. `wagon-http` does exactly this:
+Add `wagon-tck-http` and `junit-platform-suite` at test scope, declare a suite, and
+configure the `WagonTestCaseConfigurator` component. `junit-platform-suite` is what
+provides `@Suite`; without it the suite class compiles but selects nothing.
+`wagon-http` does exactly this:
```java
-@RunWith(Suite.class)
-@Suite.SuiteClasses({GetWagonTests.class, HttpsGetWagonTests.class})
+@Suite
+@SelectClasses({GetWagonTests.class, HttpsGetWagonTests.class})
public class TckTest {
}
```
@@ -433,7 +435,7 @@ method name, and every test logs `Cannot run test: null` and is treated as
unsupported — so the suite passes without having tested anything.
Wire the TCK up the way `wagon-http` does: run the TCK classes as they are, through a
-`@Suite.SuiteClasses` aggregator, and express everything provider-specific through
+`@SelectClasses` aggregator, and express everything provider-specific through
the use-case configuration rather than through a subclass.
## Running the tests
diff --git a/wagon-tcks/wagon-tck-http/sample-tck-consumer/pom.xml b/wagon-tcks/wagon-tck-http/sample-tck-consumer/pom.xml
deleted file mode 100644
index 8ee8d6ef..00000000
--- a/wagon-tcks/wagon-tck-http/sample-tck-consumer/pom.xml
+++ /dev/null
@@ -1,66 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
- <modelVersion>4.0.0</modelVersion>
-
- <groupId>org.apache.maven.wagon</groupId>
- <artifactId>sample-tck-consumer</artifactId>
- <version>1.0-SNAPSHOT</version>
-
- <name>sample-tck-consumer</name>
-
- <dependencies>
- <!-- TODO: Split this out into a sample project that shows how to use this TCK. -->
- <dependency>
- <groupId>org.apache.maven.wagon</groupId>
- <artifactId>wagon-http-lightweight</artifactId>
- <version>1.0-beta-6</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>org.apache.maven.wagon</groupId>
- <artifactId>wagon-tck-http</artifactId>
- <version>1.0-beta-7-SNAPSHOT</version>
- <scope>test</scope>
- </dependency>
- <dependency>
- <groupId>junit</groupId>
- <artifactId>junit</artifactId>
- <scope>test</scope>
- </dependency>
- </dependencies>
-
- <build>
- <pluginManagement>
- <plugins>
- <plugin>
- <artifactId>maven-compiler-plugin</artifactId>
- <version>2.0.2</version>
- <configuration>
- <source>1.5</source>
- <target>1.5</target>
- </configuration>
- </plugin>
- </plugins>
- </pluginManagement>
- </build>
-
-</project>
diff --git a/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/java/org/apache/maven/wagon/tck/http/consumer/TestSuite.java b/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/java/org/apache/maven/wagon/tck/http/consumer/TestSuite.java
deleted file mode 100644
index 23bc227f..00000000
--- a/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/java/org/apache/maven/wagon/tck/http/consumer/TestSuite.java
+++ /dev/null
@@ -1,31 +0,0 @@
-package org.apache.maven.wagon.tck.http.consumer;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import org.apache.maven.wagon.tck.http.GetWagonTests;
-import org.apache.maven.wagon.tck.http.HttpsGetWagonTests;
-import org.junit.runner.RunWith;
-import org.junit.runners.Suite;
-
-@RunWith( Suite.class )
-@Suite.SuiteClasses( { GetWagonTests.class, HttpsGetWagonTests.class } )
-public class TestSuite
-{
-}
diff --git a/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/resources/META-INF/plexus/components.xml b/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/resources/META-INF/plexus/components.xml
deleted file mode 100644
index 975bfcc3..00000000
--- a/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/resources/META-INF/plexus/components.xml
+++ /dev/null
@@ -1,32 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-Licensed to the Apache Software Foundation (ASF) under one
-or more contributor license agreements. See the NOTICE file
-distributed with this work for additional information
-regarding copyright ownership. The ASF licenses this file
-to you under the Apache License, Version 2.0 (the
-"License"); you may not use this file except in compliance
-with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
-Unless required by applicable law or agreed to in writing,
-software distributed under the License is distributed on an
-"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-KIND, either express or implied. See the License for the
-specific language governing permissions and limitations
-under the License.
--->
-<component-set>
- <!-- TODO: Split this out into a sample project that shows how to use this TCK. -->
- <components>
- <component>
- <role>org.apache.maven.wagon.tck.http.WagonTestCaseConfigurator</role>
- <implementation>org.apache.maven.wagon.tck.http.WagonTestCaseConfigurator</implementation>
- <configuration>
- <wagonHint>http</wagonHint>
- <useCaseConfigsResource>META-INF/wagon-tck/http-use-cases.xml</useCaseConfigsResource>
- </configuration>
- </component>
- </components>
-</component-set>
\ No newline at end of file
diff --git a/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/resources/META-INF/wagon-tck/http-use-cases.xml b/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/resources/META-INF/wagon-tck/http-use-cases.xml
deleted file mode 100644
index bfb6ad53..00000000
--- a/wagon-tcks/wagon-tck-http/sample-tck-consumer/src/test/resources/META-INF/wagon-tck/http-use-cases.xml
+++ /dev/null
@@ -1,26 +0,0 @@
-<!--
- Licensed to the Apache Software Foundation (ASF) under one
- or more contributor license agreements. See the NOTICE file
- distributed with this work for additional information
- regarding copyright ownership. The ASF licenses this file
- to you under the Apache License, Version 2.0 (the
- "License"); you may not use this file except in compliance
- with the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing,
- software distributed under the License is distributed on an
- "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- KIND, either express or implied. See the License for the
- specific language governing permissions and limitations
- under the License.
--->
-<useCaseConfigs>
- <highLatencyLowTimeout>
- <unsupported/>
- </highLatencyLowTimeout>
- <inifiniteLatencyTimeout>
- <unsupported/>
- </inifiniteLatencyTimeout>
-</useCaseConfigs>