You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2015/06/02 12:00:06 UTC

Re: Review Request 33274: Fix capture by reference of temporary strings in Libprocess.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33274/#review86191
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On May 20, 2015, 10:36 p.m., Joris Van Remoortere wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33274/
> -----------------------------------------------------------
> 
> (Updated May 20, 2015, 10:36 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske, Cody Maloney, Joerg Schad, Michael Park, and Till Toenshoff.
> 
> 
> Bugs: MESOS-2631
>     https://issues.apache.org/jira/browse/MESOS-2631
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/src/help.cpp 85e1bdec8d7e8f46477d0f3d88847baeca2dcc9c 
>   3rdparty/libprocess/src/process.cpp e3de3cd6b536aaaf59784360aed546512dd04dc9 
>   3rdparty/libprocess/src/tests/decoder_tests.cpp efe364a5de38c4d39fe42df243df173e7d04479a 
>   3rdparty/libprocess/src/tests/encoder_tests.cpp 784a2c71a2a7d349726f8e85bab3888b2c405aba 
>   3rdparty/libprocess/src/tests/http_tests.cpp d29cd29d8c0544671a09d204ca8ba4f24340e2de 
>   3rdparty/libprocess/src/tests/process_tests.cpp 67e582cc250a9767a389e2bd0cc68985477f3ffb 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp dea4ed8699c6c7cf5b4f5d3f014577c474dcac95 
> 
> Diff: https://reviews.apache.org/r/33274/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Joris Van Remoortere
> 
>