[GitHub] [spark] viirya commented on a diff in pull request #42542: [SPARK-44214][CORE] Support Spark Driver Live Log UI

["viirya (via GitHub)" <gi...@apache.org>]

viirya commented on code in PR #42542:
URL: https://github.com/apache/spark/pull/42542#discussion_r1300765329


##########
core/src/main/scala/org/apache/spark/util/logging/DriverLogger.scala:
##########
@@ -219,6 +223,11 @@ private[spark] object DriverLogger extends Logging {
             logError("Could not add driver logger", e)
             None
         }
+      } else if (localDriverLogEnabled) {
+        // Driver Logger is started only for Spark Driver Log UI Tab
+        new DriverLogger(conf)
+        // Return None because we don't need DFS-related logic in SparkContext and DfsAsyncWriter

Review Comment:
   Hmm, this only wants to do `addLogAppender` but doesn't need the dfs sync logic, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org