You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/05/05 23:58:40 UTC

[GitHub] [maven-surefire] Tibor17 commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution

Tibor17 commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-624366880


   @cowwoc
   This is the integration test i promised to write.
   We are missing the descriptor `module-info.java` in `src/test/java` in the impl module.
   Do you have a guess how it would be?
   I guess we should update this integration test with the descriptor so that it would cover these five issues which are related to the JPMS problem:
   https://issues.apache.org/jira/browse/SUREFIRE-1563
   https://issues.apache.org/jira/browse/SUREFIRE-1570
   https://issues.apache.org/jira/browse/SUREFIRE-1629
   https://issues.apache.org/jira/browse/SUREFIRE-1733
   https://issues.apache.org/jira/browse/SUREFIRE-1765
   
   You attached the test in SUREFIRE-1629. Perhaps your test should be compared with mine and we can add missing things.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org