You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2019/10/14 21:08:22 UTC

[GitHub] [samza] prateekm commented on a change in pull request #1187: Notifying BEM about kafkaConsumerProxy failure to prevent BEM poll-blockin in case of proxy failures

prateekm commented on a change in pull request #1187: Notifying BEM about kafkaConsumerProxy failure to prevent BEM poll-blockin in case of proxy failures
URL: https://github.com/apache/samza/pull/1187#discussion_r334661850
 
 

 ##########
 File path: samza-kafka/src/main/java/org/apache/samza/system/kafka/KafkaSystemConsumer.java
 ##########
 @@ -219,6 +219,14 @@ private void setFetchThresholds() {
         this, fetchThresholdBytes, fetchThreshold, numPartitions, perPartitionFetchThreshold, perPartitionFetchThresholdBytes);
   }
 
+  /**
+   * Invoked by {@link KafkaConsumerProxy} to notify the consumer of failure, so it can relay and stop the BEM polling.
+   * @param throwable
+   */
+  public void setProxyFailureCause(Throwable throwable) {
 
 Review comment:
   setFailureCause

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services