You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Ramesh Mani <rm...@hortonworks.com> on 2017/06/06 06:07:52 UTC
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/
-----------------------------------------------------------
(Updated June 6, 2017, 6:07 a.m.)
Review request for atlas and Madhan Neethiraj.
Bugs: ATLAS-1805
https://issues.apache.org/jira/browse/ATLAS-1805
Repository: atlas
Description
-------
ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Diffs
-----
addons/hbase-bridge-shim/pom.xml PRE-CREATION
addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HbaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/pom.xml PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseBridge.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
addons/models/0060-hbase_model.json 42fe00c
distro/src/main/assemblies/standalone-package.xml 215cb23
pom.xml 934be23
Diff: https://reviews.apache.org/r/59821/diff/1/
Testing
-------
Testing in local vm
Thanks,
Ramesh Mani
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Ramesh Mani <rm...@hortonworks.com>.
> On Sept. 1, 2017, 5:45 p.m., Madhan Neethiraj wrote:
> > addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java
> > Lines 38 (patched)
> > <https://reviews.apache.org/r/59821/diff/3/?file=1809430#file1809430line38>
> >
> > Few fields seem redundant. Please review and remove fields that are not needed.
> >
> > nameSpace ==> namespaceDescriptor should have this info
> > tableName ==> hTableDescriptor should have this info
> > hColumnDescriptors, hColumnDescriptor: is one for column-family and other for column?
nameSpace is String object, namespaceDescriptor is object with namespace and addition info. I need to have this in HbaseOperationContext as different operation from Hbase sends either namespace or namespaceDescriptor and hence having this in hbaseOperationCOntext made it simple to refer. Also this allowed me to have a same method to be used, when message are created for namespace,table,columnfamily
- Ramesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/#review184324
-----------------------------------------------------------
On Aug. 31, 2017, 10:52 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59821/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 10:52 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1805
> https://issues.apache.org/jira/browse/ATLAS-1805
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
>
>
> Diffs
> -----
>
> addons/hbase-bridge-shim/pom.xml PRE-CREATION
> addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/pom.xml PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
> addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
> addons/models/0060-hbase_model.json 3e46e06
> distro/src/main/assemblies/standalone-package.xml 215cb23
> pom.xml 8b9eee6
>
>
> Diff: https://reviews.apache.org/r/59821/diff/3/
>
>
> Testing
> -------
>
> * Review comments fixed with 2 exceptions whcih I have commented on
> * Added an IT test
> * Testing done in LOCAL VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/#review184324
-----------------------------------------------------------
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 87 (patched)
<https://reviews.apache.org/r/59821/#comment260520>
Since the hook uses Kafka notificaiton to update Atlas of HBase activities, AtlasClient should not be required. Please review and remove AtlasClient references, to avoid bringing in unused libraries in HBase hook.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 103 (patched)
<https://reviews.apache.org/r/59821/#comment260451>
executor doesn't seem to be used. Please review.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java
Lines 27 (patched)
<https://reviews.apache.org/r/59821/#comment260516>
HBaseContext seems to have all the information in HBaseEvent (operation & user). Consider removing HBaseEvent.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 44 (patched)
<https://reviews.apache.org/r/59821/#comment260511>
Consider marking this as final - as the value is set only in the constructor.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 54 (patched)
<https://reviews.apache.org/r/59821/#comment260514>
Following block is always followed by handleHBase*Operation() calls. It might be clearer to have this block inside handleHBase*Operation() methods.
if (hbaseEvent != null) {
hBaseAtlasHook.notifyAsPrivilegedAction(hbaseEvent);
}
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 134 (patched)
<https://reviews.apache.org/r/59821/#comment260513>
OPERATION.ALTER_TABLE ==> OPERATION.ALTER_NAMESPACE ?
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 141 (patched)
<https://reviews.apache.org/r/59821/#comment260512>
Hbase ==> HBase
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 150 (patched)
<https://reviews.apache.org/r/59821/#comment260518>
this 'if' seems unnecessary. Please review.
Similar ones in line #153, #218,
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 164 (patched)
<https://reviews.apache.org/r/59821/#comment260515>
Have this log call inside:
if (LOG.isDebugEnabled()) {
LOG.debug( ... );
}
to avoid unnecessary overhead of hbaseEvent.toString(). Review other handleHBase*Operation() methods as well.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java
Lines 177 (patched)
<https://reviews.apache.org/r/59821/#comment260519>
Consider moving this logic (of retrieving values from hTableDescriptor to set other fields) to HBaseContext.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java
Lines 34 (patched)
<https://reviews.apache.org/r/59821/#comment260509>
Consider renaming HBaseContext as HBaseOperationContext
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java
Lines 35 (patched)
<https://reviews.apache.org/r/59821/#comment260510>
It seems all fields would be known when an instance of HBaseContext is constructed. If yes, consider marking all as 'final' and remove set*() methods.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java
Lines 38 (patched)
<https://reviews.apache.org/r/59821/#comment260508>
Few fields seem redundant. Please review and remove fields that are not needed.
nameSpace ==> namespaceDescriptor should have this info
tableName ==> hTableDescriptor should have this info
hColumnDescriptors, hColumnDescriptor: is one for column-family and other for column?
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml
Lines 56 (patched)
<https://reviews.apache.org/r/59821/#comment260506>
It will be useful to set default log level to info. Any specific reason to set warn here, but explicitly specify INFO for org.apache.atlas and com.thinkaurelius.titan? Given import is a standalone utility (i.e. that runs outside Atlas server), it shouldn't use any class from com.thinkaurelius.titan.
addons/models/0060-hbase_model.json
Lines 67 (patched)
<https://reviews.apache.org/r/59821/#comment260505>
- attributes added to an existing type should be marked optional
- also, instead of updating model.json to add attributes, use a patch file. This will ensure that the attributes will get added in existing environments as well. The same applies for hbase_column_family as well.
- Madhan Neethiraj
On Aug. 31, 2017, 10:52 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59821/
> -----------------------------------------------------------
>
> (Updated Aug. 31, 2017, 10:52 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1805
> https://issues.apache.org/jira/browse/ATLAS-1805
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
>
>
> Diffs
> -----
>
> addons/hbase-bridge-shim/pom.xml PRE-CREATION
> addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/pom.xml PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
> addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
> addons/models/0060-hbase_model.json 3e46e06
> distro/src/main/assemblies/standalone-package.xml 215cb23
> pom.xml 8b9eee6
>
>
> Diff: https://reviews.apache.org/r/59821/diff/3/
>
>
> Testing
> -------
>
> * Review comments fixed with 2 exceptions whcih I have commented on
> * Added an IT test
> * Testing done in LOCAL VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/#review187466
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 9, 2017, 10:10 p.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59821/
> -----------------------------------------------------------
>
> (Updated Oct. 9, 2017, 10:10 p.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1805
> https://issues.apache.org/jira/browse/ATLAS-1805
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
>
>
> Diffs
> -----
>
> addons/hbase-bridge-shim/pom.xml PRE-CREATION
> addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/pom.xml PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java PRE-CREATION
> addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
> addons/models/1000-Hadoop/1060-hbase_model.json 3e46e06
> addons/models/patches/001-hbase_table_column_family_add_attribute.json PRE-CREATION
> distro/src/main/assemblies/standalone-package.xml 215cb23
> pom.xml 39ae6e7
>
>
> Diff: https://reviews.apache.org/r/59821/diff/6/
>
>
> Testing
> -------
>
> * Review comments fixed with 2 exceptions whcih I have commented on
> * Added an IT test
> * Testing done in LOCAL VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/
-----------------------------------------------------------
(Updated Oct. 9, 2017, 10:10 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Update after fixing review commands
Bugs: ATLAS-1805
https://issues.apache.org/jira/browse/ATLAS-1805
Repository: atlas
Description
-------
ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Diffs (updated)
-----
addons/hbase-bridge-shim/pom.xml PRE-CREATION
addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/pom.xml PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java PRE-CREATION
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
addons/models/1000-Hadoop/1060-hbase_model.json 3e46e06
addons/models/patches/001-hbase_table_column_family_add_attribute.json PRE-CREATION
distro/src/main/assemblies/standalone-package.xml 215cb23
pom.xml 39ae6e7
Diff: https://reviews.apache.org/r/59821/diff/6/
Changes: https://reviews.apache.org/r/59821/diff/5-6/
Testing
-------
* Review comments fixed with 2 exceptions whcih I have commented on
* Added an IT test
* Testing done in LOCAL VM
Thanks,
Ramesh Mani
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/
-----------------------------------------------------------
(Updated Sept. 11, 2017, 9:43 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Fixed review comments
Bugs: ATLAS-1805
https://issues.apache.org/jira/browse/ATLAS-1805
Repository: atlas
Description
-------
ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Diffs (updated)
-----
addons/hbase-bridge-shim/pom.xml PRE-CREATION
addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/pom.xml PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java PRE-CREATION
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
addons/models/1060-hbase_model.json 3e46e06
addons/models/patches/001-hbase_table_column_family_add_attribute.json PRE-CREATION
distro/src/main/assemblies/standalone-package.xml 215cb23
pom.xml 157122a
Diff: https://reviews.apache.org/r/59821/diff/5/
Changes: https://reviews.apache.org/r/59821/diff/4-5/
Testing
-------
* Review comments fixed with 2 exceptions whcih I have commented on
* Added an IT test
* Testing done in LOCAL VM
Thanks,
Ramesh Mani
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/#review185093
-----------------------------------------------------------
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 76 (patched)
<https://reviews.apache.org/r/59821/#comment261314>
Looks like constants in line #76 - #87 are for attribute names. It will be helpful to prefix these names with "ATTR_". Perhaps line #74 as well.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 132 (patched)
<https://reviews.apache.org/r/59821/#comment261315>
It will be useful to print exception as well:
LOG.info("Interrupt received in shutdown.", ie);
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 148 (patched)
<https://reviews.apache.org/r/59821/#comment261316>
"try {" at line #148 can move inside 'if' block at line #149.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 183 (patched)
<https://reviews.apache.org/r/59821/#comment261317>
'operation' is already part of 'hbaseOperationContext'. It will be good to not pass this as a separate argument. Same for line #190 and #197 as well.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 205 (patched)
<https://reviews.apache.org/r/59821/#comment261318>
nameSpaceRef is sent as null from the caller at line #183. It this argument is not necessary, please remove.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 272 (patched)
<https://reviews.apache.org/r/59821/#comment261319>
- namespaceReference and tableReference are sent as null from the caller at line #190. It these arguments are not necessary, please remove.
- this method doesn't seem to be used outside this class. In that case, consider marking this a private method.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 332 (patched)
<https://reviews.apache.org/r/59821/#comment261321>
- this method doesn't seem to be used outside this class. In that case, consider marking this a private method.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 350 (patched)
<https://reviews.apache.org/r/59821/#comment261320>
- namespaceReference and tableReference are sent as null from the caller at line #197. It these arguments are not necessary, please remove.
- this method doesn't seem to be used outside this class. In that case, consider marking this a private method.
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 435 (patched)
<https://reviews.apache.org/r/59821/#comment261322>
to be consistent, avoid space after "(".
Also, I see other places that miss a space after a ",". Please review and add a space after a ",".
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java
Lines 854 (patched)
<https://reviews.apache.org/r/59821/#comment261324>
'user' could be null - from line #838. Please update here to handle this case.
- Madhan Neethiraj
On Sept. 10, 2017, 7:04 a.m., Ramesh Mani wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59821/
> -----------------------------------------------------------
>
> (Updated Sept. 10, 2017, 7:04 a.m.)
>
>
> Review request for atlas and Madhan Neethiraj.
>
>
> Bugs: ATLAS-1805
> https://issues.apache.org/jira/browse/ATLAS-1805
>
>
> Repository: atlas
>
>
> Description
> -------
>
> ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
>
>
> Diffs
> -----
>
> addons/hbase-bridge-shim/pom.xml PRE-CREATION
> addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/pom.xml PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
> addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java PRE-CREATION
> addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
> addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
> addons/models/1060-hbase_model.json 3e46e06
> addons/models/patches/001-hbase_table_column_family_add_attribute.json PRE-CREATION
> distro/src/main/assemblies/standalone-package.xml 215cb23
> pom.xml 157122a
>
>
> Diff: https://reviews.apache.org/r/59821/diff/4/
>
>
> Testing
> -------
>
> * Review comments fixed with 2 exceptions whcih I have commented on
> * Added an IT test
> * Testing done in LOCAL VM
>
>
> Thanks,
>
> Ramesh Mani
>
>
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/
-----------------------------------------------------------
(Updated Sept. 10, 2017, 7:04 a.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Fixed review comments.
Bugs: ATLAS-1805
https://issues.apache.org/jira/browse/ATLAS-1805
Repository: atlas
Description
-------
ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Diffs (updated)
-----
addons/hbase-bridge-shim/pom.xml PRE-CREATION
addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/pom.xml PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseOperationContext.java PRE-CREATION
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
addons/models/1060-hbase_model.json 3e46e06
addons/models/patches/001-hbase_table_column_family_add_attribute.json PRE-CREATION
distro/src/main/assemblies/standalone-package.xml 215cb23
pom.xml 157122a
Diff: https://reviews.apache.org/r/59821/diff/4/
Changes: https://reviews.apache.org/r/59821/diff/3-4/
Testing
-------
* Review comments fixed with 2 exceptions whcih I have commented on
* Added an IT test
* Testing done in LOCAL VM
Thanks,
Ramesh Mani
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/
-----------------------------------------------------------
(Updated Aug. 31, 2017, 10:52 p.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Patch after reviews
Bugs: ATLAS-1805
https://issues.apache.org/jira/browse/ATLAS-1805
Repository: atlas
Description
-------
ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Diffs (updated)
-----
addons/hbase-bridge-shim/pom.xml PRE-CREATION
addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/pom.xml PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
addons/models/0060-hbase_model.json 3e46e06
distro/src/main/assemblies/standalone-package.xml 215cb23
pom.xml 8b9eee6
Diff: https://reviews.apache.org/r/59821/diff/3/
Changes: https://reviews.apache.org/r/59821/diff/2-3/
Testing
-------
* Review comments fixed with 2 exceptions whcih I have commented on
* Added an IT test
* Testing done in LOCAL VM
Thanks,
Ramesh Mani
Re: Review Request 59821: ATLAS-1805:Provide an Atlas hook to send
Hbase Namespace/Table/column family metadata to Atlas
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59821/
-----------------------------------------------------------
(Updated June 23, 2017, 12:22 a.m.)
Review request for atlas and Madhan Neethiraj.
Changes
-------
Fixed review comments
Bugs: ATLAS-1805
https://issues.apache.org/jira/browse/ATLAS-1805
Repository: atlas
Description
-------
ATLAS-1805: Provide an Atlas hook to send Hbase Namespace/Table/column family metadata to Atlas
Diffs (updated)
-----
addons/hbase-bridge-shim/pom.xml PRE-CREATION
addons/hbase-bridge-shim/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/pom.xml PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/bridge/HBaseAtlasHook.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/event/HBaseEvent.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessor.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/hook/HBaseAtlasCoprocessorBase.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseContext.java PRE-CREATION
addons/hbase-bridge/src/main/java/org/apache/atlas/hbase/model/HBaseDataTypes.java PRE-CREATION
addons/hbase-bridge/src/main/resources/atlas-hbase-import-log4j.xml PRE-CREATION
addons/hbase-bridge/src/test/java/org/apache/atlas/hbase/HBaseAtlasHookTest.java PRE-CREATION
addons/models/0060-hbase_model.json 42fe00c
distro/src/main/assemblies/standalone-package.xml 215cb23
pom.xml ebc07e2
Diff: https://reviews.apache.org/r/59821/diff/2/
Changes: https://reviews.apache.org/r/59821/diff/1-2/
Testing (updated)
-------
* Review comments fixed with 2 exceptions whcih I have commented on
* Added an IT test
* Testing done in LOCAL VM
Thanks,
Ramesh Mani