You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/01/19 00:52:30 UTC
Re: Review Request: Added libprofiler.a to the python module objects,
removed perftools from the mesos Makefile.am
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9020/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 11:52 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
Removed the perftools linking from the mesos makefile.
Summary (updated)
-----------------
Added libprofiler.a to the python module objects, removed perftools from the mesos Makefile.am
Description
-------
This fixes a regression in the python tests to the the addition of gperftools.
Diffs (updated)
-----
src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0
src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e
Diff: https://reviews.apache.org/r/9020/diff/
Testing
-------
make check OSX (works)
make check Linux, still seeing:
$ ./src/examples/python/test-framework
Traceback (most recent call last):
File "/home/bmahler/git/mesos/build/../src/examples/python/test_framework.py", line 23, in <module>
import mesos
File "build/bdist.linux-x86_64/egg/mesos.py", line 22, in <module>
File "build/bdist.linux-x86_64/egg/_mesos.py", line 7, in <module>
File "build/bdist.linux-x86_64/egg/_mesos.py", line 6, in __bootstrap__
ImportError: /home/bmahler/.python-eggs/mesos-0.12.0-py2.6-linux-x86_64.egg-tmp/_mesos.so: undefined symbol: ProfilerStart
Thanks,
Ben Mahler
Re: Review Request: Added libprofiler.a to the python module objects,
removed perftools from mesos/third_party.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9020/
-----------------------------------------------------------
(Updated Jan. 30, 2013, 11:46 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Changes
-------
This now removes perftools from mesos/third_party!
All tests passing on OSX, Linux.
Summary (updated)
-----------------
Added libprofiler.a to the python module objects, removed perftools from mesos/third_party.
Description
-------
This fixes a regression in the python tests to the the addition of gperftools.
Diffs (updated)
-----
src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0
src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e
third_party/Makefile.am 4da4ee5c2e6733c4aa8242ec845c77b063761884
third_party/gperftools-2.0.tar.gz 13b03cae44e5e6dcfdec4756b975f425b2ea73cf
third_party/libprocess/third_party/Makefile.am 3b47c37add67b875303a4586a7ef940c522dafd1
third_party/versions.am 8e98f4808579604c3779887e0b50178cc4b71f88
Diff: https://reviews.apache.org/r/9020/diff/
Testing
-------
make check (on OSX & Linux)
Thanks,
Ben Mahler
Re: Review Request: Added libprofiler.a to the python module objects,
removed perftools from the mesos Makefile.am
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9020/#review15625
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 18, 2013, 11:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9020/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 11:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This fixes a regression in the python tests to the the addition of gperftools.
>
>
> Diffs
> -----
>
> src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0
> src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e
>
> Diff: https://reviews.apache.org/r/9020/diff/
>
>
> Testing
> -------
>
> make check (on OSX & Linux)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added libprofiler.a to the python module objects,
removed perftools from the mesos Makefile.am
Posted by Ben Mahler <be...@gmail.com>.
> On Jan. 30, 2013, 8:55 p.m., Benjamin Hindman wrote:
> > src/python/setup.py.in, line 24
> > <https://reviews.apache.org/r/9020/diff/2/?file=250292#file250292line24>
> >
> > Let's get the gperftools from libprocess/third_party, just like we do from libev below. In fact, let's just move this line down by the libev line and update the comment to reflect the how/why of including both libev and gperftools.
> >
> > A nice side effect here is we can kill the tarball from Mesos third_party! One more step to eliminating the redundant tarballs.
Thanks and done!
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9020/#review15886
-----------------------------------------------------------
On Jan. 18, 2013, 11:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9020/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 11:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This fixes a regression in the python tests to the the addition of gperftools.
>
>
> Diffs
> -----
>
> src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0
> src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e
>
> Diff: https://reviews.apache.org/r/9020/diff/
>
>
> Testing
> -------
>
> make check (on OSX & Linux)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added libprofiler.a to the python module objects,
removed perftools from the mesos Makefile.am
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9020/#review15886
-----------------------------------------------------------
src/python/setup.py.in
<https://reviews.apache.org/r/9020/#comment34161>
Let's get the gperftools from libprocess/third_party, just like we do from libev below. In fact, let's just move this line down by the libev line and update the comment to reflect the how/why of including both libev and gperftools.
A nice side effect here is we can kill the tarball from Mesos third_party! One more step to eliminating the redundant tarballs.
- Benjamin Hindman
On Jan. 18, 2013, 11:52 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9020/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2013, 11:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> This fixes a regression in the python tests to the the addition of gperftools.
>
>
> Diffs
> -----
>
> src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0
> src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e
>
> Diff: https://reviews.apache.org/r/9020/diff/
>
>
> Testing
> -------
>
> make check (on OSX & Linux)
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request: Added libprofiler.a to the python module objects,
removed perftools from the mesos Makefile.am
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9020/
-----------------------------------------------------------
(Updated Jan. 18, 2013, 11:52 p.m.)
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
This fixes a regression in the python tests to the the addition of gperftools.
Diffs
-----
src/Makefile.am 0ab59b75b2955c532d0833f132bdaffe323838d0
src/python/setup.py.in a564cd8a0664a962bc71fc63f2a873737c275a8e
Diff: https://reviews.apache.org/r/9020/diff/
Testing (updated)
-------
make check (on OSX & Linux)
Thanks,
Ben Mahler