You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by "Wei-hao-Li (via GitHub)" <gi...@apache.org> on 2025/06/06 00:04:25 UTC
[PR] Fix arrary index out-of-bounds in agg query with align by device when cross region [iotdb]
Wei-hao-Li opened a new pull request, #15656:
URL: https://github.com/apache/iotdb/pull/15656
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix arrary index out-of-bounds in agg query with align by device when cross region [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 commented on code in PR #15656:
URL: https://github.com/apache/iotdb/pull/15656#discussion_r2148942885
##########
iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/planner/distribution/SourceRewriter.java:
##########
@@ -313,6 +353,21 @@ public List<PlanNode> visitDeviceView(DeviceViewNode node, DistributionPlanConte
}
}
+ private static List<Expression> getWithDeviceExpressions(
+ FunctionExpression aggExpression, String device) {
+ return aggExpression.getExpressions().stream()
+ .map(
+ // process each argument of FunctionExpression
+ argument -> {
+ checkArgument(
+ argument instanceof TimeSeriesOperand,
+ "Argument of AggregationFunction should be TimeSeriesOperand here");
+ return new TimeSeriesOperand(
Review Comment:
add dataType
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix arrary index out-of-bounds in agg query with align by device when cross region [iotdb]
Posted by "JackieTien97 (via GitHub)" <gi...@apache.org>.
JackieTien97 merged PR #15656:
URL: https://github.com/apache/iotdb/pull/15656
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org