You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@xalan.apache.org by "David Marston (JIRA)" <xa...@xml.apache.org> on 2005/05/18 21:44:51 UTC
[jira] Created: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Need correct HTML serialization of special attributes, even with copy-of
------------------------------------------------------------------------
Key: XALANJ-2121
URL: http://issues.apache.org/jira/browse/XALANJ-2121
Project: XalanJ2
Type: Bug
Components: Serialization
Reporter: David Marston
Priority: Minor
The situation illustrated in test case attribset17...
<Input Type="checkbox">
<xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
</Input>
should be emitted as
<Input Type="checkbox" CHECKED>
and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Morris Kwan (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=comments#action_66575 ]
Morris Kwan commented on XALANJ-2121:
-------------------------------------
I have reviewed Brian's patch. It looks good to me.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Assigned: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau reassigned XALANJ-2121:
-------------------------------------
Assign To: Brian Minchau
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau updated XALANJ-2121:
----------------------------------
Xalan info: [PatchAvailable]
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau updated XALANJ-2121:
----------------------------------
Attachment: patch3.to.ToHTMLStream.for.2121.txt
Added some Intnet-Explorer and Netscape extensions that have the "nowrap" empty
attribute on div, src, and tr HTML elements.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt, patch3.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau updated XALANJ-2121:
----------------------------------
Fix Version: 2.7
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Fix For: 2.7
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt, patch3.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=comments#action_12319254 ]
Brian Minchau commented on XALANJ-2121:
---------------------------------------
Dave,
Xalan-J 2.7 was released Aug 8, 2005 and should have the fix. Please verify so we can close this issue.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Fix For: 2.7
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt, patch3.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=comments#action_66637 ]
Brian Minchau commented on XALANJ-2121:
---------------------------------------
patch3 was applied to CVS.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt, patch3.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau updated XALANJ-2121:
----------------------------------
Attachment: patch.to.ToHTMLStream.for.2121.txt
Attaching patch that adds the missing information that specifies additional
attributes as being empty for the particular elements.
I also put all of the attribute information chunked together by the element
to which it applies, and put the chunks in alphabetic order by element name.
It's just easer to read.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=comments#action_66591 ]
Brian Minchau commented on XALANJ-2121:
---------------------------------------
This stylesheet doesn't produce decent HTML, but if you check its output it does serialize all of the attributes on HTML elements as empty:
<?xml version="1.0"?>
<xsl:stylesheet
version="1.0"
xmlns:xsl="http://www.w3.org/1999/XSL/Transform">
<xsl:output method="html" />
<xsl:template match="/">
<html><head>
<input type="radio" checked="checked"/>
<dl compact="compact"/>
<ol compact="compact"/>
<ul compact="compact"/>
<dir compact="compact"/>
<menu compact="compact"/>
<object declare="declare" />
<script defer="defer" />
<select disabled="disabled"/>
<input disabled="disabled"/>
<optgroup disabled="disabled"/>
<option disabled="disabled"/>
<button disabled="disabled"/>
<textarea disabled="disabled"/>
<input ismap="ismap"/>
<img ismap="ismap"/>
<select multiple="multiple"/>
<area nohref="nohref"/>
<frame noresize="noresize"/>
<hr noshade="noshade"/>
<th nowrap="nowrap" />
<td nowrap="nowrap" />
<input readonly="readonly" />
<textarea readonly="readonly" />
<option selected="selected" />
</head></html>
</xsl:template>
</xsl:stylesheet>
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "David Marston (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=comments#action_65699 ]
David Marston commented on XALANJ-2121:
---------------------------------------
Two more pieces of information from Brian:
1. We may be doing the right thing for some element/attribute combinations but not others, which implies that the test cases need to cover all combinations. The attributes compact, noresize, noshade, and nowrap are always bad, and readonly is sometimes bad.
2. Brian wanted a note to review any code that could be tripped up by slightly different ways to check that the attribute or element names are not namespace-qualified. (e.g., null vs. "" to denote no namespace)
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Updated: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau updated XALANJ-2121:
----------------------------------
Attachment: patch2.to.ToHTMLStream.for.2121.txt
Fixed a typo in the oritinal patch.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Resolved: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=all ]
Brian Minchau resolved XALANJ-2121:
-----------------------------------
Resolution: Fixed
The second patch was applied to CVS head branch.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Assignee: Brian Minchau
> Priority: Minor
> Attachments: patch.to.ToHTMLStream.for.2121.txt, patch2.to.ToHTMLStream.for.2121.txt
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org
[jira] Commented: (XALANJ-2121) Need correct HTML serialization of special attributes, even with copy-of
Posted by "Brian Minchau (JIRA)" <xa...@xml.apache.org>.
[ http://issues.apache.org/jira/browse/XALANJ-2121?page=comments#action_65700 ]
Brian Minchau commented on XALANJ-2121:
---------------------------------------
According to the HTML spec, here are the 12 valueless HTML attributes, each followed by a list of elements that they can appear on:
checked -> input
compact -> dl ol ul dir menu
declare -> object
defer -> script
disabled -> select input optgroup option button textarea
ismap -> input img
multiple -> select
nohref -> area
noresize -> frame
noshade -> hr
nowrap -> th td
readonly -> input textarea
selected -> option
A code inspection of ToHTMLStream.java shows that not all of these are recognized as valueless in the Trie created to hold information about HTML elements and their attributes. The following are not correctly recognized as valueless:
compact -> dl ol ul dir menu
noresize -> frame
noshade -> hr
nowrap -> th td
readonly -> textarea
One of those not recognized is the nowrap on a <td> element, as noted by Dave within this issue,
but we should clean them all up together.
> Need correct HTML serialization of special attributes, even with copy-of
> ------------------------------------------------------------------------
>
> Key: XALANJ-2121
> URL: http://issues.apache.org/jira/browse/XALANJ-2121
> Project: XalanJ2
> Type: Bug
> Components: Serialization
> Reporter: David Marston
> Priority: Minor
>
> The situation illustrated in test case attribset17...
> <Input Type="checkbox">
> <xsl:attribute name="CHECKED">CHECKED</xsl:attribute>
> </Input>
> should be emitted as
> <Input Type="checkbox" CHECKED>
> and there is an output test (34, IIRC) that shows the same thing for LREs. We don't (yet) have a test for xsl:copy-of, which failed
> for me on <td nowrap>. I think Brian Minchau will advise about whether xsl:copy or xsl:element use-attribute-sets="foo" or any other case is a separate code path that needs separate testing.
> Notice that in the example above, we also should emit the element as an empty/unclosed element, in addition to reducing the CHECKED attribute.
> Brian M. and Henry Z. think that the set of attributes requiring this treatment is: checked, compact, declare, defer, disabled,
> ismap, multiple, nohref, noresize, noshade, nowrap, readonly, selected.
> Also revisit XALANJ-296, which is about XSLTC.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: xalan-dev-unsubscribe@xml.apache.org
For additional commands, e-mail: xalan-dev-help@xml.apache.org