You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/21 06:59:28 UTC
[GitHub] [shardingsphere] tristaZero opened a new pull request #9116: Support single table joinning sharding table
tristaZero opened a new pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116
Ref #8284
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #9116: Support single table joining sharding table
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #9116: Support single table joining sharding table
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9116: Support single table joining sharding table
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116#discussion_r561676392
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `singleTableRuleExists `
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `singleTableRuleExists `
Please fix javadoc, `Judge whetner single table rule exists or not` is better
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `singleTableRuleExists `
Please fix javadoc, `Judge whether single table rule exists or not` is better
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `isSingleTableRuleExists `
Please fix javadoc, `Judge whether single table rule exists or not` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9116: Support single table joining sharding table
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116#discussion_r561676392
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `isSingleTableRuleExists `
Please fix javadoc, `Judge whether single table rule exists or not` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9116: Support single table joining sharding table
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116#discussion_r561676392
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `singleTableRuleExists `
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu commented on a change in pull request #9116: Support single table joining sharding table
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #9116:
URL: https://github.com/apache/shardingsphere/pull/9116#discussion_r561676392
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `singleTableRuleExists `
Please fix javadoc, `Judge whetner single table rule exists or not` is better
##########
File path: shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-common/src/main/java/org/apache/shardingsphere/sharding/rule/ShardingRule.java
##########
@@ -302,6 +302,16 @@ public boolean tableRuleExists(final Collection<String> logicTableNames) {
return logicTableNames.stream().anyMatch(each -> findTableRule(each).isPresent() || isBroadcastTable(each));
}
+ /**
+ * Single table rule exists.
+ *
+ * @param logicTableNames logic table names
+ * @return whether single table rule exists for logic tables
+ */
+ public boolean singleTableRuleExists(final Collection<String> logicTableNames) {
Review comment:
Method name should be `singleTableRuleExists `
Please fix javadoc, `Judge whether single table rule exists or not` is better
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org