You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by bu...@apache.org on 2017/10/05 11:58:07 UTC
[Bug 61584] New: NPE in XDGFPage getPageOffset: check for x instead
of y
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584
Bug ID: 61584
Summary: NPE in XDGFPage getPageOffset: check for x instead of
y
Product: POI
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P2
Component: XDGF
Assignee: dev@poi.apache.org
Reporter: marko@friedemann.email
Target Milestone: ---
XDGFPage getPageOffset contains a wrong check for null, causing an NPE for
.vsdx documents that don't have the YRulerOrigin set.
The code in question has been there ever since this was contributed, so it
appears to affect all versions.
,-- XDGFPage.java, lines 99ff [1] --
99 if (xoffcell != null)
100 xoffset = Double.parseDouble(xoffcell.getValue());
101
102 if (xoffcell != null)
103 yoffset = Double.parseDouble(yoffcell.getValue());
`-----
The fix is trivial, line 102 should check yoffcell for being null.
[1]
https://apache.googlesource.com/poi/+/refs/heads/trunk/src/ooxml/java/org/apache/poi/xdgf/usermodel/XDGFPage.java#102
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584
Marko Friedemann <ma...@friedemann.email> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marko@friedemann.email
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584
--- Comment #2 from Marko Friedemann <ma...@friedemann.email> ---
I am afraid I can't, as the document in question originated with a customer and
I don't have a Visio version capable of generating .vsdx.
While I can understand the question of reproducability and verification, could
an exception be made here, as this specific bug should be trivial and obvious
enough to be handled?
If it helps, I added the fix to my copy and can now import the document without
issue.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584
--- Comment #4 from virtuald <du...@virtualroadside.com> ---
No longer have Visio installed either*
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584
Dominik Stadler <do...@gmx.at> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #1 from Dominik Stadler <do...@gmx.at> ---
Can you provide a sample document that we can use to verify the fix?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
[Bug 61584] NPE in XDGFPage getPageOffset: check for x instead of y
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=61584
virtuald <du...@virtualroadside.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|NEEDINFO |RESOLVED
--- Comment #3 from virtuald <du...@virtualroadside.com> ---
I no longer have Visio installed with, but you're right that this is obviously
a typo. Pushed fix @ 1812240.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org