You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by nikhilkh <gi...@git.apache.org> on 2016/04/26 02:36:59 UTC
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-android/pull/299
CB-11153 Use Gradle 2.8 correctly for building Android projects
This improves gradle build performance by 1 second on my machine
@jasongin; @infil00p; @riknoll to help review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-android gradlever
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/299.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #299
----
commit f2a9e5c8ccca9f223bc651d3c95bb41a46e32df5
Author: Nikhil Khandelwal <ni...@microsoft.com>
Date: 2016-04-26T00:32:56Z
CB-11153 Use Gradle 2.8 correctly for building Android projects
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214900265
OK, I merged this in, because I need it for something I'm working on :P
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214809471
I just ended up moving to version 2.13 which is the latest - and the perf is even a bit better than version 2.8. I looked at Android docs and did not find anything about one version being more compatible than other - so we should be fine.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/299
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214762095
Why 2.8? Why not 2.10? Is 2.10 slower than 2.8? Will this break other users somehow?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214899779
Good call on updating this to Gradle 2.13, I just updated to 2.1.0 beta, and Android Studio just showed me a bunch of complaints about importing the project.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android pull request: CB-11153 Use Gradle 2.8 correctly fo...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the pull request:
https://github.com/apache/cordova-android/pull/299#issuecomment-214615174
## [Current coverage][cc-pull] is **100%**
> Merging [#299][cc-pull] into [master][cc-base-branch] will increase coverage by **+63.87%**
```diff
@@ master #299 diff @@
=======================================
Files 11 11
Lines 927 1690 +763
Methods 0 204 +204
Branches 167 167
=======================================
+ Hits 335 1690 +1355
+ Misses 592 0 -592
Partials 0 0
```
1. 10 files (not in diff) in `...emplates/cordova/lib` were modified. [more](https://codecov.io/gh/apache/cordova-android/commit/e809144cf377f3d1c9bd9d0303c6ea7e5cdda4ba/changes?src=pr#62696E2F74656D706C617465732F636F72646F76612F6C6962)
- Misses `-503`
- Hits `+1121`
1. 1 files (not in diff) in `...in/templates/cordova` were modified. [more](https://codecov.io/gh/apache/cordova-android/commit/e809144cf377f3d1c9bd9d0303c6ea7e5cdda4ba/changes?src=pr#62696E2F74656D706C617465732F636F72646F7661)
- Misses `-89`
- Hits `+234`
[][cc-pull]
> Powered by [Codecov](https://codecov.io?src=pr). Last updated by e809144
[cc-base-branch]: https://codecov.io/gh/apache/cordova-android/branch/master?src=pr
[cc-pull]: https://codecov.io/gh/apache/cordova-android/pull/299?src=pr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org