You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/09/12 11:54:37 UTC

[GitHub] [flink-connector-elasticsearch] snuyanzin opened a new pull request, #29: [hotfix] Move away from deprecated RestHighLevelClient#bulkAsync

snuyanzin opened a new pull request, #29:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/29

   ## What is the purpose of the change
   
   The PR makes use `RestHighLevelClient#bulkAsync` with RequestOptions instead of deprecated one as it recommended in javadoc [1] and as it is already done for elastic7 [2]
   [1] https://github.com/elastic/elasticsearch/blob/6.8/client/rest-high-level/src/main/java/org/elasticsearch/client/RestHighLevelClient.java#L498-L507
   [2] https://github.com/apache/flink/blob/master/flink-connectors/flink-connector-elasticsearch7/src/main/java/org/apache/flink/connector/elasticsearch/sink/Elasticsearch7SinkBuilder.java#L85-L88
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-elasticsearch] zentol commented on pull request #29: [hotfix] Move away from deprecated RestHighLevelClient#bulkAsync

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #29:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/29#issuecomment-1245099140

   @snuyanzin Could you rebase the PR? Ci shouldn't be broken anymore :see_no_evil: 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #29: [hotfix] Move away from deprecated RestHighLevelClient#bulkAsync

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/29#issuecomment-1243628755

   Thanks for opening this pull request! Please check out our contributing guidelines. (https://flink.apache.org/contributing/how-to-contribute.html)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-elasticsearch] zentol merged pull request #29: [hotfix] Move away from deprecated RestHighLevelClient#bulkAsync

Posted by GitBox <gi...@apache.org>.
zentol merged PR #29:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/29


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-elasticsearch] snuyanzin commented on pull request #29: [hotfix] Move away from deprecated RestHighLevelClient#bulkAsync

Posted by GitBox <gi...@apache.org>.
snuyanzin commented on PR #29:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/29#issuecomment-1245217082

   done, yes not it seems a bit greener
   thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-connector-elasticsearch] boring-cyborg[bot] commented on pull request #29: [hotfix] Move away from deprecated RestHighLevelClient#bulkAsync

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on PR #29:
URL: https://github.com/apache/flink-connector-elasticsearch/pull/29#issuecomment-1245230107

   Awesome work, congrats on your first merged pull request!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org