[GitHub] [apisix-ingress-controller] tao12345666333 commented on a diff in pull request #1819: chore: updates latest go mod lib and modifies the ginkgo install instruction

["tao12345666333 (via GitHub)" <gi...@apache.org>]

tao12345666333 commented on code in PR #1819:
URL: https://github.com/apache/apisix-ingress-controller/pull/1819#discussion_r1180995988


##########
Makefile:
##########
@@ -150,7 +150,8 @@ e2e-test-local: kind-up e2e-test
 .PHONY: ginkgo-check
 ginkgo-check:
 ifeq ("$(wildcard $(GINKGO))", "")
-	@echo "ERROR: Need to install ginkgo first, run: go get -u github.com/onsi/ginkgo/v2/ginkgo@v2.9.2 or go install -mod=mod github.com/onsi/ginkgo/v2/ginkgo@v2.9.2"
+	@echo "ERROR: Need to install ginkgo first, run: go get -u github.com/onsi/ginkgo/v2/ginkgo@v2.9.2 and go install -mod=mod github.com/onsi/ginkgo/v2/ginkgo@v2.9.2"

Review Comment:
   The go get installs for versions prior to Go 1.16. 
   
   And it can be installed via go install after 1.16



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org