You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@karaf.apache.org by Christian Schneider <ch...@die-schneider.net> on 2012/05/22 14:19:00 UTC

Add a scope feature-url

I would like to add a scope feature-url and move the feature:url-* 
commands there.
The idea is that command completion will work much better this way.

Currently we have the following completions:

 > feature:<tab>
feature:info                 feature:install              
feature:list                 feature:repository-list
feature:repository-remove    feature:uninstall            
feature:url-add              feature:url-choose
feature:url-list             feature:url-refresh          
feature:url-remove           feature:version-list
^ This mixes the commands about feature urls and the commands about 
features which is bad

After the change we could do:

 >feature:<tab>
feature:info                 feature:install              
feature:list        feature:uninstall

 >feature-url:<tab>
feature-url:add        feature-url:choose     feature-url:list       
feature-url:refresh    feature-url:remove

Which looks much more cohesive.

The subshell would also work better with that change. There even the 
prefixes are gone in the completion and you simply have the commands
you can do on features or feature urls.

Btw. What are the two feature:repository-* and feature:version-list 
commands good for? I have never noticed them before and honestly never 
missed them.

Christian

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Achim Nierbeck <bc...@googlemail.com>.
I second Ioannis on this, right now I don't see much of a difference
either and not much
benefit of it.

regards, Achim

2012/5/22 Ioannis Canellos <io...@gmail.com>:
> The idea of nesting sub shells seems interesting, but currently there is
> little need for it. As it already have been added it adds too much
> fragmentation.
>
> Now regarding to the original comment about separating the features:url-*
> commands. I think that it doesn't change much.
> Usually the user will type go by typing something like: feat <TAB> ->
> features: and then press an other letter or two and complete the rest of
> the commands. So we have 2 tabs so far and maybe one more to specify
> url-add, url-remove etc. Total 3 <TAB>s.
>
> If we add a new scope say: feature-url, then the user will go: feat<TAB> ->
> features and then will need to either press ":" or "u" and <TAB> again and
> so on.
>
> So in both cases we have the same ammount of effort unless the user types
> the whole scope and part of the command name by himself before using
> completion.
>
> So I don't see much of a difference.
>
> *
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Twitter: iocanel
> *



-- 

Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
OPS4J Pax for Vaadin
<http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
Lead
blog <http://notizblog.nierbeck.de/>

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
I agree for the short term. The danger that we only change it but not 
really make it better is quite high.
Still I have the feeling that it currently is not really optimal. I will 
give it some more thought.

Christian

Am 22.05.2012 21:21, schrieb Ioannis Canellos:
> In terms of completion this would make a difference. However, it is lacking
> context in my opinion.
> For example when a user sees the repo scope, he can be easily get confused
> and think that this refers to maven repos etc.
>
> Generally, speaking we need to be careful regarding the commands scope.
> If the scope is too generic, then it will gather a lot of commands under it
> and in the it will loose its purpose (such case were the osgi commands,
> they used to be an umbrella for many different things).
> On the other hand, if we normalize scopes too much and start
> splitting concepts across different scopes. the number of scope will be
> hard for the users to follow. Moreover, it will weaken the sub
> shells concept (there will be not much use to enter a subshells with only
> just a couple of commands).
>
> The key here is balance. I feel the currently the features scope is well
> balance and I think we should leave them as they are.
>


-- 

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
Most of the commands changed in karaf 3 as we swapped the order of 
verb-subject to subject verb. So unfortunately you will have do adapt a 
lot in your scripting.
My changes will not really make it worse.

Christian


Am 25.05.2012 17:11, schrieb Chris Geer:
> On Fri, May 25, 2012 at 12:17 AM, Christian Schneider<
> chris@die-schneider.net>  wrote:
>
>> I looked into the feature commands a little deeper and I think I can do
>> more than just changing the scope.
>>
>> See https://issues.apache.org/**jira/browse/KARAF-1502<https://issues.apache.org/jira/browse/KARAF-1502>
>>
>> I already did some of the implementation and I think it looks much better
>> than what we have now.
>>
>> If the command names are going to be changing will there at least be alias
> matching the existing commands by default, or easily enabled? I tend to
> agree that the changes are minor enough for a human to figure out but we
> tend to do a decent amount of scripting that uses these commands so
> changing them will require a decent amount of rework on our part. It's not
> the end of the world but aliases would at least cause this change to be
> relatively non-breaking (unless the arguments are changing too) until we
> got a chance to update all our scripts.
>
> Chris
>
>> Christian
>>
>> Am 22.05.2012 21:21, schrieb Ioannis Canellos:
>>
>>> In terms of completion this would make a difference. However, it is
>>> lacking
>>>
>>> context in my opinion.
>>> For example when a user sees the repo scope, he can be easily get confused
>>> and think that this refers to maven repos etc.
>>>
>>> Generally, speaking we need to be careful regarding the commands scope.
>>> If the scope is too generic, then it will gather a lot of commands under
>>> it
>>> and in the it will loose its purpose (such case were the osgi commands,
>>> they used to be an umbrella for many different things).
>>> On the other hand, if we normalize scopes too much and start
>>> splitting concepts across different scopes. the number of scope will be
>>> hard for the users to follow. Moreover, it will weaken the sub
>>> shells concept (there will be not much use to enter a subshells with only
>>> just a couple of commands).
>>>
>>> The key here is balance. I feel the currently the features scope is well
>>> balance and I think we should leave them as they are.
>>>
>>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Chris Geer <ch...@cxtsoftware.com>.
Maybe this isn't possible, but is there a way to make command text be
completely configurable? I know there are currently aliases, but that gets
real ugly real quick with multiple ways to do the same thing. It would be
nice to be able to define Command Sets that map command object to the term
that the shell will recognize which overwrites the default. It would be
even slicker if there were pre-defined sets that people could select
between like "legacy" and "new and fancy". That would give you the freedom
to restructure how the commands are actually implemented in code (sub
commands..) without impacting how the commands are called. So if the
default was "features:repo:add" but there was a way to make that
"features:addurl" by replacing the first one I think you could get
backwards compatibility and be able to refactor as needed.

Just a thought. It doesn't solve the "value" concern but it would fix the
backwards compatibility concern and allow people migrate to the new
commands at their own pace. I'm with Ioannis, I like the new proposed
structure in a lot of ways and dislike how some of the commands are now but
that is quickly outweighed by breaking compatibility.

Chris

On Fri, May 25, 2012 at 2:49 PM, Achim Nierbeck <bc...@googlemail.com>wrote:

> Christian,
>
> basically I just can repeat myself I don't see much of a difference, and
> again I have to
> second Ioannis for the reasons. And the thing that really made me do a -1
> here
> our Users don't see a reason to change either.
> This is just a repetition of all what has been said/written before
>
> Achim
>
>
> Am 25.05.2012 19:10, schrieb Ioannis Canellos:
>
>  So having "feature:repo:list" sounds better to me than
>>> "feature:repo-list".
>>>
>>>  The thing is that its not *that* better to justify a change and all the
>> effort that such a change requires (both from the broader community and
>> from our existing user).
>>
>> Just to clarify. I do like the idea of nesting sub shells and the concept
>> of separating them using the ":" as it might be useful for downstream
>> projects or people building their custom distribution and have tens of
>> commands under single scope. So I am +1 to that part.
>>
>> I am -1 on changing our existing commands, to adopt to such concept for
>> the
>> reasons already explained.
>>
>>
>
> --
> - Apache Karaf<http://karaf.apache.org/**>  Committer&  PMC
> - OPS4J Pax Web<http://wiki.ops4j.org/**display/paxweb/Pax+Web/<http://wiki.ops4j.org/display/paxweb/Pax+Web/>>
>    Committer&  Project Lead
> - Blog<http://notizblog.**nierbeck.de/ <http://notizblog.nierbeck.de/>>
>
>

Re: Add a scope feature-url

Posted by Achim Nierbeck <bc...@googlemail.com>.
Christian,

basically I just can repeat myself I don't see much of a difference, and 
again I have to
second Ioannis for the reasons. And the thing that really made me do a 
-1 here
our Users don't see a reason to change either.
This is just a repetition of all what has been said/written before

Achim


Am 25.05.2012 19:10, schrieb Ioannis Canellos:
>> So having "feature:repo:list" sounds better to me than "feature:repo-list".
>>
> The thing is that its not *that* better to justify a change and all the
> effort that such a change requires (both from the broader community and
> from our existing user).
>
> Just to clarify. I do like the idea of nesting sub shells and the concept
> of separating them using the ":" as it might be useful for downstream
> projects or people building their custom distribution and have tens of
> commands under single scope. So I am +1 to that part.
>
> I am -1 on changing our existing commands, to adopt to such concept for the
> reasons already explained.
>


-- 
- Apache Karaf<http://karaf.apache.org/>  Committer&  PMC
- OPS4J Pax Web<http://wiki.ops4j.org/display/paxweb/Pax+Web/>    Committer&  Project Lead
- Blog<http://notizblog.nierbeck.de/>


Re: Add a scope feature-url

Posted by Ioannis Canellos <io...@gmail.com>.
>
> So having "feature:repo:list" sounds better to me than "feature:repo-list".
>

The thing is that its not *that* better to justify a change and all the
effort that such a change requires (both from the broader community and
from our existing user).

Just to clarify. I do like the idea of nesting sub shells and the concept
of separating them using the ":" as it might be useful for downstream
projects or people building their custom distribution and have tens of
commands under single scope. So I am +1 to that part.

I am -1 on changing our existing commands, to adopt to such concept for the
reasons already explained.

-- 
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
Ok so I will keep the noun-verb structure. Still I think we should 
consider moving the nouns to sub scopes.
We already use the scope as a noun like in "feature:list" instead of 
"feature-list". So having "feature:repo:list" sounds better to me than 
"feature:repo-list".

You are right though that we should be consinstent. So we either have to 
change all or keep all.

Christian


Am 25.05.2012 17:50, schrieb Ioannis Canellos:
> I see the following problems here:
>
>     1. We have already communicated to our users that our future commands
>     structure will be scope:noun-verb and provided alias for this. Changing the
>     structure again seems not right.
>     2. We need to make sure that the whole ecosystem is using similar
>     command structure (e.g. camel, cxf, smx). If we are to change again we need
>     to coordinate the rest of the projects, too.
>     3. The added value is really small to justify a change that will affect
>     so many things (mostly refering to the impact to the projects providing
>     karaf commands).
>
> So, I would prefer to keep things as they are now.
>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Ioannis Canellos <io...@gmail.com>.
I see the following problems here:

   1. We have already communicated to our users that our future commands
   structure will be scope:noun-verb and provided alias for this. Changing the
   structure again seems not right.
   2. We need to make sure that the whole ecosystem is using similar
   command structure (e.g. camel, cxf, smx). If we are to change again we need
   to coordinate the rest of the projects, too.
   3. The added value is really small to justify a change that will affect
   so many things (mostly refering to the impact to the projects providing
   karaf commands).

So, I would prefer to keep things as they are now.

-- 
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
Hi Achim,

would you mind to explain what you dislike?

Christian

Am 25.05.2012 17:18, schrieb Achim Nierbeck:
> I see this as a valid show-stopper.
> To give this some more weight, here's my official -1 for this idea!
>
> Achim
>

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Guillaume Nodet <gn...@gmail.com>.
Right, I think we need to try to keep compatibility as much as possible.
We've had already aliases in 2.2.x and I actually think they're bad
for the following reasons:
  * they make the completion harder
  * they can't be relied upon until 3.0 has been released
I'd think aliases may be better placed in 3.0 to have backward
compatibility (instead of 2.x for forward compatibility) and I also
think they may be better written has being optional (i.e. having a
simple way to enable them - or eventually disable, depending on what
we choose).

On Fri, May 25, 2012 at 5:18 PM, Achim Nierbeck <bc...@googlemail.com> wrote:
> I see this as a valid show-stopper.
> To give this some more weight, here's my official -1 for this idea!
>
> Achim
>
> 2012/5/25 Chris Geer <ch...@cxtsoftware.com>:
>> On Fri, May 25, 2012 at 12:17 AM, Christian Schneider <
>> chris@die-schneider.net> wrote:
>>
>>> I looked into the feature commands a little deeper and I think I can do
>>> more than just changing the scope.
>>>
>>> See https://issues.apache.org/**jira/browse/KARAF-1502<https://issues.apache.org/jira/browse/KARAF-1502>
>>>
>>> I already did some of the implementation and I think it looks much better
>>> than what we have now.
>>>
>>> If the command names are going to be changing will there at least be alias
>> matching the existing commands by default, or easily enabled? I tend to
>> agree that the changes are minor enough for a human to figure out but we
>> tend to do a decent amount of scripting that uses these commands so
>> changing them will require a decent amount of rework on our part. It's not
>> the end of the world but aliases would at least cause this change to be
>> relatively non-breaking (unless the arguments are changing too) until we
>> got a chance to update all our scripts.
>>
>> Chris
>>
>>>
>>> Christian
>>>
>>> Am 22.05.2012 21:21, schrieb Ioannis Canellos:
>>>
>>>> In terms of completion this would make a difference. However, it is
>>>> lacking
>>>>
>>>> context in my opinion.
>>>> For example when a user sees the repo scope, he can be easily get confused
>>>> and think that this refers to maven repos etc.
>>>>
>>>> Generally, speaking we need to be careful regarding the commands scope.
>>>> If the scope is too generic, then it will gather a lot of commands under
>>>> it
>>>> and in the it will loose its purpose (such case were the osgi commands,
>>>> they used to be an umbrella for many different things).
>>>> On the other hand, if we normalize scopes too much and start
>>>> splitting concepts across different scopes. the number of scope will be
>>>> hard for the users to follow. Moreover, it will weaken the sub
>>>> shells concept (there will be not much use to enter a subshells with only
>>>> just a couple of commands).
>>>>
>>>> The key here is balance. I feel the currently the features scope is well
>>>> balance and I think we should leave them as they are.
>>>>
>>>>
>>>
>>> --
>>> Christian Schneider
>>> http://www.liquid-reality.de
>>>
>>> Open Source Architect
>>> Talend Application Integration Division http://www.talend.com
>>>
>>>
>
>
>
> --
>
> Apache Karaf <http://karaf.apache.org/> Committer & PMC
> OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
> Committer & Project Lead
> OPS4J Pax for Vaadin
> <http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
> Lead
> blog <http://notizblog.nierbeck.de/>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Add a scope feature-url

Posted by Achim Nierbeck <bc...@googlemail.com>.
I see this as a valid show-stopper.
To give this some more weight, here's my official -1 for this idea!

Achim

2012/5/25 Chris Geer <ch...@cxtsoftware.com>:
> On Fri, May 25, 2012 at 12:17 AM, Christian Schneider <
> chris@die-schneider.net> wrote:
>
>> I looked into the feature commands a little deeper and I think I can do
>> more than just changing the scope.
>>
>> See https://issues.apache.org/**jira/browse/KARAF-1502<https://issues.apache.org/jira/browse/KARAF-1502>
>>
>> I already did some of the implementation and I think it looks much better
>> than what we have now.
>>
>> If the command names are going to be changing will there at least be alias
> matching the existing commands by default, or easily enabled? I tend to
> agree that the changes are minor enough for a human to figure out but we
> tend to do a decent amount of scripting that uses these commands so
> changing them will require a decent amount of rework on our part. It's not
> the end of the world but aliases would at least cause this change to be
> relatively non-breaking (unless the arguments are changing too) until we
> got a chance to update all our scripts.
>
> Chris
>
>>
>> Christian
>>
>> Am 22.05.2012 21:21, schrieb Ioannis Canellos:
>>
>>> In terms of completion this would make a difference. However, it is
>>> lacking
>>>
>>> context in my opinion.
>>> For example when a user sees the repo scope, he can be easily get confused
>>> and think that this refers to maven repos etc.
>>>
>>> Generally, speaking we need to be careful regarding the commands scope.
>>> If the scope is too generic, then it will gather a lot of commands under
>>> it
>>> and in the it will loose its purpose (such case were the osgi commands,
>>> they used to be an umbrella for many different things).
>>> On the other hand, if we normalize scopes too much and start
>>> splitting concepts across different scopes. the number of scope will be
>>> hard for the users to follow. Moreover, it will weaken the sub
>>> shells concept (there will be not much use to enter a subshells with only
>>> just a couple of commands).
>>>
>>> The key here is balance. I feel the currently the features scope is well
>>> balance and I think we should leave them as they are.
>>>
>>>
>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>>



-- 

Apache Karaf <http://karaf.apache.org/> Committer & PMC
OPS4J Pax Web <http://wiki.ops4j.org/display/paxweb/Pax+Web/>
Committer & Project Lead
OPS4J Pax for Vaadin
<http://team.ops4j.org/wiki/display/PAXVAADIN/Home> Commiter & Project
Lead
blog <http://notizblog.nierbeck.de/>

Re: Add a scope feature-url

Posted by Chris Geer <ch...@cxtsoftware.com>.
On Fri, May 25, 2012 at 12:17 AM, Christian Schneider <
chris@die-schneider.net> wrote:

> I looked into the feature commands a little deeper and I think I can do
> more than just changing the scope.
>
> See https://issues.apache.org/**jira/browse/KARAF-1502<https://issues.apache.org/jira/browse/KARAF-1502>
>
> I already did some of the implementation and I think it looks much better
> than what we have now.
>
> If the command names are going to be changing will there at least be alias
matching the existing commands by default, or easily enabled? I tend to
agree that the changes are minor enough for a human to figure out but we
tend to do a decent amount of scripting that uses these commands so
changing them will require a decent amount of rework on our part. It's not
the end of the world but aliases would at least cause this change to be
relatively non-breaking (unless the arguments are changing too) until we
got a chance to update all our scripts.

Chris

>
> Christian
>
> Am 22.05.2012 21:21, schrieb Ioannis Canellos:
>
>> In terms of completion this would make a difference. However, it is
>> lacking
>>
>> context in my opinion.
>> For example when a user sees the repo scope, he can be easily get confused
>> and think that this refers to maven repos etc.
>>
>> Generally, speaking we need to be careful regarding the commands scope.
>> If the scope is too generic, then it will gather a lot of commands under
>> it
>> and in the it will loose its purpose (such case were the osgi commands,
>> they used to be an umbrella for many different things).
>> On the other hand, if we normalize scopes too much and start
>> splitting concepts across different scopes. the number of scope will be
>> hard for the users to follow. Moreover, it will weaken the sub
>> shells concept (there will be not much use to enter a subshells with only
>> just a couple of commands).
>>
>> The key here is balance. I feel the currently the features scope is well
>> balance and I think we should leave them as they are.
>>
>>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>
>

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
I looked into the feature commands a little deeper and I think I can do 
more than just changing the scope.

See https://issues.apache.org/jira/browse/KARAF-1502

I already did some of the implementation and I think it looks much 
better than what we have now.

Christian

Am 22.05.2012 21:21, schrieb Ioannis Canellos:
> In terms of completion this would make a difference. However, it is lacking
> context in my opinion.
> For example when a user sees the repo scope, he can be easily get confused
> and think that this refers to maven repos etc.
>
> Generally, speaking we need to be careful regarding the commands scope.
> If the scope is too generic, then it will gather a lot of commands under it
> and in the it will loose its purpose (such case were the osgi commands,
> they used to be an umbrella for many different things).
> On the other hand, if we normalize scopes too much and start
> splitting concepts across different scopes. the number of scope will be
> hard for the users to follow. Moreover, it will weaken the sub
> shells concept (there will be not much use to enter a subshells with only
> just a couple of commands).
>
> The key here is balance. I feel the currently the features scope is well
> balance and I think we should leave them as they are.
>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Ioannis Canellos <io...@gmail.com>.
In terms of completion this would make a difference. However, it is lacking
context in my opinion.
For example when a user sees the repo scope, he can be easily get confused
and think that this refers to maven repos etc.

Generally, speaking we need to be careful regarding the commands scope.
If the scope is too generic, then it will gather a lot of commands under it
and in the it will loose its purpose (such case were the osgi commands,
they used to be an umbrella for many different things).
On the other hand, if we normalize scopes too much and start
splitting concepts across different scopes. the number of scope will be
hard for the users to follow. Moreover, it will weaken the sub
shells concept (there will be not much use to enter a subshells with only
just a couple of commands).

The key here is balance. I feel the currently the features scope is well
balance and I think we should leave them as they are.

-- 
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
You are right. It will not be much of a difference still I have the 
feeling that mixing feature and feature-url is not ideal.

How about calling the feature-url commands repo like:
repo:add
repo:remove
repo:list

That should improve the tab completion. I would be missing the relation 
to features in that but it would be more usable.

Christian

Am 22.05.2012 18:44, schrieb Ioannis Canellos:
> The idea of nesting sub shells seems interesting, but currently there is
> little need for it. As it already have been added it adds too much
> fragmentation.
>
> Now regarding to the original comment about separating the features:url-*
> commands. I think that it doesn't change much.
> Usually the user will type go by typing something like: feat<TAB>  ->
> features: and then press an other letter or two and complete the rest of
> the commands. So we have 2 tabs so far and maybe one more to specify
> url-add, url-remove etc. Total 3<TAB>s.
>
> If we add a new scope say: feature-url, then the user will go: feat<TAB>  ->
> features and then will need to either press ":" or "u" and<TAB>  again and
> so on.
>
> So in both cases we have the same ammount of effort unless the user types
> the whole scope and part of the command name by himself before using
> completion.
>
> So I don't see much of a difference.
>
> *
>
> **
> Blog: http://iocanel.blogspot.com
> **
> Twitter: iocanel
> *
>


-- 

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Ioannis Canellos <io...@gmail.com>.
The idea of nesting sub shells seems interesting, but currently there is
little need for it. As it already have been added it adds too much
fragmentation.

Now regarding to the original comment about separating the features:url-*
commands. I think that it doesn't change much.
Usually the user will type go by typing something like: feat <TAB> ->
features: and then press an other letter or two and complete the rest of
the commands. So we have 2 tabs so far and maybe one more to specify
url-add, url-remove etc. Total 3 <TAB>s.

If we add a new scope say: feature-url, then the user will go: feat<TAB> ->
features and then will need to either press ":" or "u" and <TAB> again and
so on.

So in both cases we have the same ammount of effort unless the user types
the whole scope and part of the command name by himself before using
completion.

So I don't see much of a difference.

*

**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
Yes fragmentation is an issue. We have to make sure the informations on 
the top level are good enough so people know what subshell to look into.
Of course we can still provide a help list of all commands too so people 
can grep it if they are unsure where a certain command is located.

On the other hand I think a hierarchy makes a lot of sense. Currently we 
have 142 commands at the top level (with a default karaf). This is quite 
overwhelming for users.
If they would simply see 10 subshells with nice descriptions of the 
purpose that would probably be a much better guidance.

Christian


Am 22.05.2012 15:35, schrieb Guillaume Nodet:
> Not sure how feasible that is, because it impacts lots of things, but why not.
> I'm not sure separating too much is a good idea, as you kinda loose
> the overview of what commands are related.
> If we'd do what you suggest, completion would only show resources, and
> I suppose the help command too, so it kinda fragments things a bit.
> I guess that would make sense if we end up with dozens of commands in
> the same subshell, for the features we only have a handful, and we are
> even talking about reducing that number.
>
> On Tue, May 22, 2012 at 3:19 PM, Christian Schneider
> <ch...@die-schneider.net>  wrote:
>> How about:
>>
>> jms:queue:browse
>> jms:queue:clear
>> jms:topic:browse
>> jms:connection:list
>>
>> So you can enter a subshell in two levels.
>>
>> On the jms level you see:
>> queue:browse
>> queue:clear
>> topic:browse
>> connection:list
>>
>> On the jms:queue level you see:
>> browse
>> clear
>>
>> This is even quite near the concept we have now. We just need to use a ":"
>> instead of the "-".
>>
>> Coming back to the feature case perhaps we can do this:
>>
>> feature:url:add
>> feature:url:remove
>> feature:url:list
>> feature:install
>> feature:uninstall
>> feature:list
>>
>> (We could also use repo instead of url. Not sure about that though.)
>> The downside to the above is that completion is not better than today but it
>> would nicely implement the resource view already.
>>
>> Christian
>>
>>

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Guillaume Nodet <gn...@gmail.com>.
Not sure how feasible that is, because it impacts lots of things, but why not.
I'm not sure separating too much is a good idea, as you kinda loose
the overview of what commands are related.
If we'd do what you suggest, completion would only show resources, and
I suppose the help command too, so it kinda fragments things a bit.
I guess that would make sense if we end up with dozens of commands in
the same subshell, for the features we only have a handful, and we are
even talking about reducing that number.

On Tue, May 22, 2012 at 3:19 PM, Christian Schneider
<ch...@die-schneider.net> wrote:
> How about:
>
> jms:queue:browse
> jms:queue:clear
> jms:topic:browse
> jms:connection:list
>
> So you can enter a subshell in two levels.
>
> On the jms level you see:
> queue:browse
> queue:clear
> topic:browse
> connection:list
>
> On the jms:queue level you see:
> browse
> clear
>
> This is even quite near the concept we have now. We just need to use a ":"
> instead of the "-".
>
> Coming back to the feature case perhaps we can do this:
>
> feature:url:add
> feature:url:remove
> feature:url:list
> feature:install
> feature:uninstall
> feature:list
>
> (We could also use repo instead of url. Not sure about that though.)
> The downside to the above is that completion is not better than today but it
> would nicely implement the resource view already.
>
> Christian
>
> Am 22.05.2012 14:59, schrieb Guillaume Nodet:
>
>> I don't quite agree with that.  I think subshell should be command (or
>> service) related and use resource nouns as prefixes to the command as
>> now.
>> I don't really see something like:
>>   jms-queue:browse
>>   jms-queue:clear
>>   jms-topic:browse
>>   jms-connection:list
>>
>> Rather
>>    jms:queue-browse
>>    jms:queue-clear
>>    jms:connection-list
>> or maybe
>>    jms browse queue
>> But the later is really not what we have so far, so that would require
>> just a full rework of all commands.  Not sure if it's worth it.
>>
>> On Tue, May 22, 2012 at 2:51 PM, Christian Schneider
>> <ch...@die-schneider.net>  wrote:
>>>
>>> If we want to separate feature and feature-url  depends a bit on the
>>> meaning
>>> of a scope or subshell. I would like to design them around resources.
>>> In this view features are a resource and feature-urls are another
>>> resource.
>>>
>>> If you look at it this way you have a nice separation of nouns and verbs.
>>> The resources (subshells) are the nouns and the commands are the verbs.
>>> I think this view is much more natural than just grouping commands.
>>>
>>> It will also allow to extend this to more unusual usages that we
>>> currently
>>> can not yet support like:
>>>>
>>>> jms:myqueue
>>>
>>> (jms:myqueue)>  <tab>
>>> drop    purge    send    browse
>>
>> I don't think that's a good idea to go that way.  If you start with
>> the resources, you can't really use completion to refine what you
>> want, because you'd have all the resources first (and that can be a
>> lot) and they would be all together, not grouped by type of resources.
>>  Also, when you type a command, you usually know what you want to do,
>> so starting by the resource does not really help imho.
>>
>>> So a queue could also be a resource and have commands. This is a bit far
>>> away from where we are now but designing the subshells with resources in
>>> mind would help us to get there.
>>>
>>>
>>> Christian
>>>
>>> Am 22.05.2012 14:22, schrieb Guillaume Nodet:
>>>>
>>>> I think the repository commands use the argument as the repository
>>>>
>>>> name instead of the repository url.
>>>>
>>>> Not sure about separating both.  It does not really help with
>>>> completion (as you need to type the ':' in addition to few<tab>    for
>>>> example), and given those are related, it looks more natural to me.  I
>>>> think subshells should be really independent and that's not the case
>>>> imho.
>>>>
>>>>
>>> --
>>> Christian Schneider
>>> http://www.liquid-reality.de
>>>
>>> Open Source Architect
>>> Talend Application Integration Division http://www.talend.com
>>>
>>
>>
>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
How about:

jms:queue:browse
jms:queue:clear
jms:topic:browse
jms:connection:list

So you can enter a subshell in two levels.

On the jms level you see:
queue:browse
queue:clear
topic:browse
connection:list

On the jms:queue level you see:
browse
clear

This is even quite near the concept we have now. We just need to use a 
":" instead of the "-".

Coming back to the feature case perhaps we can do this:

feature:url:add
feature:url:remove
feature:url:list
feature:install
feature:uninstall
feature:list

(We could also use repo instead of url. Not sure about that though.)
The downside to the above is that completion is not better than today 
but it would nicely implement the resource view already.

Christian

Am 22.05.2012 14:59, schrieb Guillaume Nodet:
> I don't quite agree with that.  I think subshell should be command (or
> service) related and use resource nouns as prefixes to the command as
> now.
> I don't really see something like:
>    jms-queue:browse
>    jms-queue:clear
>    jms-topic:browse
>    jms-connection:list
>
> Rather
>     jms:queue-browse
>     jms:queue-clear
>     jms:connection-list
> or maybe
>     jms browse queue
> But the later is really not what we have so far, so that would require
> just a full rework of all commands.  Not sure if it's worth it.
>
> On Tue, May 22, 2012 at 2:51 PM, Christian Schneider
> <ch...@die-schneider.net>  wrote:
>> If we want to separate feature and feature-url  depends a bit on the meaning
>> of a scope or subshell. I would like to design them around resources.
>> In this view features are a resource and feature-urls are another resource.
>>
>> If you look at it this way you have a nice separation of nouns and verbs.
>> The resources (subshells) are the nouns and the commands are the verbs.
>> I think this view is much more natural than just grouping commands.
>>
>> It will also allow to extend this to more unusual usages that we currently
>> can not yet support like:
>>> jms:myqueue
>> (jms:myqueue)>  <tab>
>> drop    purge    send    browse
> I don't think that's a good idea to go that way.  If you start with
> the resources, you can't really use completion to refine what you
> want, because you'd have all the resources first (and that can be a
> lot) and they would be all together, not grouped by type of resources.
>   Also, when you type a command, you usually know what you want to do,
> so starting by the resource does not really help imho.
>
>> So a queue could also be a resource and have commands. This is a bit far
>> away from where we are now but designing the subshells with resources in
>> mind would help us to get there.
>>
>>
>> Christian
>>
>> Am 22.05.2012 14:22, schrieb Guillaume Nodet:
>>> I think the repository commands use the argument as the repository
>>>
>>> name instead of the repository url.
>>>
>>> Not sure about separating both.  It does not really help with
>>> completion (as you need to type the ':' in addition to few<tab>    for
>>> example), and given those are related, it looks more natural to me.  I
>>> think subshells should be really independent and that's not the case
>>> imho.
>>>
>>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>
>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Guillaume Nodet <gn...@gmail.com>.
I don't quite agree with that.  I think subshell should be command (or
service) related and use resource nouns as prefixes to the command as
now.
I don't really see something like:
  jms-queue:browse
  jms-queue:clear
  jms-topic:browse
  jms-connection:list

Rather
   jms:queue-browse
   jms:queue-clear
   jms:connection-list
or maybe
   jms browse queue
But the later is really not what we have so far, so that would require
just a full rework of all commands.  Not sure if it's worth it.

On Tue, May 22, 2012 at 2:51 PM, Christian Schneider
<ch...@die-schneider.net> wrote:
> If we want to separate feature and feature-url  depends a bit on the meaning
> of a scope or subshell. I would like to design them around resources.
> In this view features are a resource and feature-urls are another resource.
>
> If you look at it this way you have a nice separation of nouns and verbs.
> The resources (subshells) are the nouns and the commands are the verbs.
> I think this view is much more natural than just grouping commands.
>
> It will also allow to extend this to more unusual usages that we currently
> can not yet support like:
>> jms:myqueue
> (jms:myqueue)> <tab>
> drop    purge    send    browse

I don't think that's a good idea to go that way.  If you start with
the resources, you can't really use completion to refine what you
want, because you'd have all the resources first (and that can be a
lot) and they would be all together, not grouped by type of resources.
 Also, when you type a command, you usually know what you want to do,
so starting by the resource does not really help imho.

>
> So a queue could also be a resource and have commands. This is a bit far
> away from where we are now but designing the subshells with resources in
> mind would help us to get there.
>
>
> Christian
>
> Am 22.05.2012 14:22, schrieb Guillaume Nodet:
>>
>> I think the repository commands use the argument as the repository
>>
>> name instead of the repository url.
>>
>> Not sure about separating both.  It does not really help with
>> completion (as you need to type the ':' in addition to few<tab>  for
>> example), and given those are related, it looks more natural to me.  I
>> think subshells should be really independent and that's not the case
>> imho.
>>
>>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
If we want to separate feature and feature-url  depends a bit on the 
meaning of a scope or subshell. I would like to design them around 
resources.
In this view features are a resource and feature-urls are another resource.

If you look at it this way you have a nice separation of nouns and 
verbs. The resources (subshells) are the nouns and the commands are the 
verbs.
I think this view is much more natural than just grouping commands.

It will also allow to extend this to more unusual usages that we 
currently can not yet support like:
 > jms:myqueue
(jms:myqueue)> <tab>
drop    purge    send    browse

So a queue could also be a resource and have commands. This is a bit far 
away from where we are now but designing the subshells with resources in 
mind would help us to get there.

Christian

Am 22.05.2012 14:22, schrieb Guillaume Nodet:
> I think the repository commands use the argument as the repository
> name instead of the repository url.
>
> Not sure about separating both.  It does not really help with
> completion (as you need to type the ':' in addition to few<tab>  for
> example), and given those are related, it looks more natural to me.  I
> think subshells should be really independent and that's not the case
> imho.
>
>

-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Guillaume Nodet <gn...@gmail.com>.
Sounds good to me.

On Tue, May 22, 2012 at 2:30 PM, Christian Schneider
<ch...@die-schneider.net> wrote:
> About the feature:repository commands. How about allowing the repo name in
> the feature:url-* commands additionally to the url. That would have the same
> effect and would save us some commands.
>
> I also think about doing the same with the feature:url-choose command. We
> could allow the symbolic names in feature:url-add like feature:url-add camel
> 2.9.2 so the feature:url-choose could also be eliminated.
>
> Christian
>
>
> Am 22.05.2012 14:22, schrieb Guillaume Nodet:
>
>> I think the repository commands use the argument as the repository
>> name instead of the repository url.
>>
>> Not sure about separating both.  It does not really help with
>> completion (as you need to type the ':' in addition to few<tab>  for
>> example), and given those are related, it looks more natural to me.  I
>> think subshells should be really independent and that's not the case
>> imho.
>>
>> On Tue, May 22, 2012 at 2:19 PM, Christian Schneider
>> <ch...@die-schneider.net>  wrote:
>>>
>>> I would like to add a scope feature-url and move the feature:url-*
>>> commands
>>> there.
>>> The idea is that command completion will work much better this way.
>>>
>>> Currently we have the following completions:
>>>
>>>> feature:<tab>
>>>
>>> feature:info                 feature:install              feature:list
>>>           feature:repository-list
>>> feature:repository-remove    feature:uninstall            feature:url-add
>>>            feature:url-choose
>>> feature:url-list             feature:url-refresh
>>>  feature:url-remove
>>>           feature:version-list
>>> ^ This mixes the commands about feature urls and the commands about
>>> features
>>> which is bad
>>>
>>> After the change we could do:
>>>
>>>> feature:<tab>
>>>
>>> feature:info                 feature:install              feature:list
>>>  feature:uninstall
>>>
>>>> feature-url:<tab>
>>>
>>> feature-url:add        feature-url:choose     feature-url:list
>>> feature-url:refresh    feature-url:remove
>>>
>>> Which looks much more cohesive.
>>>
>>> The subshell would also work better with that change. There even the
>>> prefixes are gone in the completion and you simply have the commands
>>> you can do on features or feature urls.
>>>
>>> Btw. What are the two feature:repository-* and feature:version-list
>>> commands
>>> good for? I have never noticed them before and honestly never missed
>>> them.
>>>
>>> Christian
>>>
>>> --
>>> Christian Schneider
>>> http://www.liquid-reality.de
>>>
>>> Open Source Architect
>>> Talend Application Integration Division http://www.talend.com
>>>
>>
>>
>
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com

Re: Add a scope feature-url

Posted by Christian Schneider <ch...@die-schneider.net>.
About the feature:repository commands. How about allowing the repo name 
in the feature:url-* commands additionally to the url. That would have 
the same effect and would save us some commands.

I also think about doing the same with the feature:url-choose command. 
We could allow the symbolic names in feature:url-add like 
feature:url-add camel 2.9.2 so the feature:url-choose could also be 
eliminated.

Christian


Am 22.05.2012 14:22, schrieb Guillaume Nodet:
> I think the repository commands use the argument as the repository
> name instead of the repository url.
>
> Not sure about separating both.  It does not really help with
> completion (as you need to type the ':' in addition to few<tab>  for
> example), and given those are related, it looks more natural to me.  I
> think subshells should be really independent and that's not the case
> imho.
>
> On Tue, May 22, 2012 at 2:19 PM, Christian Schneider
> <ch...@die-schneider.net>  wrote:
>> I would like to add a scope feature-url and move the feature:url-* commands
>> there.
>> The idea is that command completion will work much better this way.
>>
>> Currently we have the following completions:
>>
>>> feature:<tab>
>> feature:info                 feature:install              feature:list
>>            feature:repository-list
>> feature:repository-remove    feature:uninstall            feature:url-add
>>             feature:url-choose
>> feature:url-list             feature:url-refresh          feature:url-remove
>>            feature:version-list
>> ^ This mixes the commands about feature urls and the commands about features
>> which is bad
>>
>> After the change we could do:
>>
>>> feature:<tab>
>> feature:info                 feature:install              feature:list
>>   feature:uninstall
>>
>>> feature-url:<tab>
>> feature-url:add        feature-url:choose     feature-url:list
>> feature-url:refresh    feature-url:remove
>>
>> Which looks much more cohesive.
>>
>> The subshell would also work better with that change. There even the
>> prefixes are gone in the completion and you simply have the commands
>> you can do on features or feature urls.
>>
>> Btw. What are the two feature:repository-* and feature:version-list commands
>> good for? I have never noticed them before and honestly never missed them.
>>
>> Christian
>>
>> --
>> Christian Schneider
>> http://www.liquid-reality.de
>>
>> Open Source Architect
>> Talend Application Integration Division http://www.talend.com
>>
>
>


-- 
Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com


Re: Add a scope feature-url

Posted by Guillaume Nodet <gn...@gmail.com>.
I think the repository commands use the argument as the repository
name instead of the repository url.

Not sure about separating both.  It does not really help with
completion (as you need to type the ':' in addition to few<tab> for
example), and given those are related, it looks more natural to me.  I
think subshells should be really independent and that's not the case
imho.

On Tue, May 22, 2012 at 2:19 PM, Christian Schneider
<ch...@die-schneider.net> wrote:
> I would like to add a scope feature-url and move the feature:url-* commands
> there.
> The idea is that command completion will work much better this way.
>
> Currently we have the following completions:
>
>> feature:<tab>
> feature:info                 feature:install              feature:list
>           feature:repository-list
> feature:repository-remove    feature:uninstall            feature:url-add
>            feature:url-choose
> feature:url-list             feature:url-refresh          feature:url-remove
>           feature:version-list
> ^ This mixes the commands about feature urls and the commands about features
> which is bad
>
> After the change we could do:
>
>>feature:<tab>
> feature:info                 feature:install              feature:list
>  feature:uninstall
>
>>feature-url:<tab>
> feature-url:add        feature-url:choose     feature-url:list
> feature-url:refresh    feature-url:remove
>
> Which looks much more cohesive.
>
> The subshell would also work better with that change. There even the
> prefixes are gone in the completion and you simply have the commands
> you can do on features or feature urls.
>
> Btw. What are the two feature:repository-* and feature:version-list commands
> good for? I have never noticed them before and honestly never missed them.
>
> Christian
>
> --
> Christian Schneider
> http://www.liquid-reality.de
>
> Open Source Architect
> Talend Application Integration Division http://www.talend.com
>



-- 
------------------------
Guillaume Nodet
------------------------
Blog: http://gnodet.blogspot.com/
------------------------
FuseSource, Integration everywhere
http://fusesource.com