You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/07/07 00:22:35 UTC

[GitHub] [kafka] spal1 commented on a change in pull request #8863: KAFKA-8528: Expose Trogdor-specific JMX metrics for Tasks and Agents

spal1 commented on a change in pull request #8863:
URL: https://github.com/apache/kafka/pull/8863#discussion_r450545145



##########
File path: tools/src/main/java/org/apache/kafka/trogdor/agent/Agent.java
##########
@@ -92,6 +93,8 @@
 
     private final Time time;
 
+    final TrogdorMetrics trogdorMetrics;

Review comment:
       A `TrogdorMetrics` was shared between the `Coordinator` and `Agent` solely to allow for a count of the active agents to be added to the existing metrics. There doesn't seem to be a way to do this only from the `Coordinator`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org