svn commit: r1290841 - /incubator/ooo/trunk/main/solenv/bin/modules/installer/systemactions.pm

[yd...@apache.org]

Author: ydario
Date: Sat Feb 18 18:34:11 2012
New Revision: 1290841

URL: http://svn.apache.org/viewvc?rev=1290841&view=rev
Log:
i118923 - OS/2 port: remove destination file before copy.

Modified:
    incubator/ooo/trunk/main/solenv/bin/modules/installer/systemactions.pm

Modified: incubator/ooo/trunk/main/solenv/bin/modules/installer/systemactions.pm
URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/solenv/bin/modules/installer/systemactions.pm?rev=1290841&r1=1290840&r2=1290841&view=diff
==============================================================================
--- incubator/ooo/trunk/main/solenv/bin/modules/installer/systemactions.pm (original)
+++ incubator/ooo/trunk/main/solenv/bin/modules/installer/systemactions.pm Sat Feb 18 18:34:11 2012
@@ -426,6 +426,12 @@ sub copy_one_file
 
 	my ($returnvalue, $infoline);
 	
+
+	# copy returns 0 if files are identical :-(
+	if ( $installer::globals::isos2 ) {
+		unlink($dest);
+	}
+
 	my $copyreturn = copy($source, $dest);
 		
 	if ($copyreturn)

Re: svn commit: r1290841 - /incubator/ooo/trunk/main/solenv/inc/_tg_app.mk

[Yuri Dario <mc...@mclink.it>]

Hi Herbert,

> This is probably mostly a good change, but I wonder why the change 
> removed the lines
>    .IF "$(VERBOSE)" == "TRUE"
>    [...]
>    .ENDIF

the code was not in sync with real commands, and there isn't something
similar for dlls or other platforms (at least for link stage), so I 
cleaned it.

> Did I overlook something that there is another mechanism now that makes 
> the build more verbose?

you are right, there isn't. but I prefer to run dmake -n to check for 
effective commands.


-- 
Bye,

	Yuri Dario

/*
 * OS/2 open source software
 * http://web.os2power.com/yuri
 * http://www.netlabs.org
*/

Re: svn commit: r1290841 - /incubator/ooo/trunk/main/solenv/inc/_tg_app.mk

[Herbert Duerr <hd...@apache.org>]

> Author: ydario
> Date: Sat Feb 18 18:31:52 2012
> New Revision: 1290840
>
> URL: http://svn.apache.org/viewvc?rev=1290840&view=rev
> Log:
 > i118923 - OS/2 port: solenv build system patches

This is probably mostly a good change, but I wonder why the change 
removed the lines
   .IF "$(VERBOSE)" == "TRUE"
   [...]
   .ENDIF

They are usually very helpful when one is debugging a build problem. 
E.g. doing a
   build verbose=t
often helps to find out why an include path or a library wasn't found. 
Did I overlook something that there is another mechanism now that makes 
the build more verbose?

Herbert