You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "codecov-commenter (via GitHub)" <gi...@apache.org> on 2023/08/16 07:42:27 UTC
[GitHub] [pinot] codecov-commenter commented on pull request #11358: Stop table data manager before shutdown
codecov-commenter commented on PR #11358:
URL: https://github.com/apache/pinot/pull/11358#issuecomment-1680119149
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#11358](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1bd7340) into [master](https://app.codecov.io/gh/apache/pinot/commit/2d30e28bedea29d264b0d7946ebb3f0e2cf1b5cc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (2d30e28) will **increase** coverage by `61.25%`.
> Report is 245 commits behind head on master.
> The diff coverage is `11.11%`.
```diff
@@ Coverage Diff @@
## master #11358 +/- ##
=============================================
+ Coverage 0.11% 61.37% +61.25%
- Complexity 0 6511 +6511
=============================================
Files 2190 2233 +43
Lines 118056 120097 +2041
Branches 17873 18223 +350
=============================================
+ Hits 137 73709 +73572
+ Misses 117899 40983 -76916
- Partials 20 5405 +5385
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `0.00% <0.00%> (?)` | |
| integration1temurin11 | `?` | |
| integration1temurin17 | `?` | |
| integration1temurin20 | `?` | |
| integration2 | `0.00% <0.00%> (?)` | |
| integration2temurin11 | `?` | |
| integration2temurin17 | `?` | |
| integration2temurin20 | `?` | |
| java-11 | `14.24% <0.00%> (?)` | |
| java-17 | `61.35% <11.11%> (?)` | |
| java-20 | `61.36% <11.11%> (?)` | |
| temurin | `61.37% <11.11%> (?)` | |
| unittests1 | `66.79% <22.22%> (?)` | |
| unittests1temurin11 | `?` | |
| unittests1temurin17 | `?` | |
| unittests1temurin20 | `?` | |
| unittests2 | `14.64% <0.00%> (?)` | |
| unittests2temurin11 | `?` | |
| unittests2temurin17 | `?` | |
| unittests2temurin20 | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../data/manager/offline/OfflineTableDataManager.java](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvb2ZmbGluZS9PZmZsaW5lVGFibGVEYXRhTWFuYWdlci5qYXZh) | `80.00% <0.00%> (+80.00%)` | :arrow_up: |
| [...t/segment/local/data/manager/TableDataManager.java](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VnbWVudC1sb2NhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3Qvc2VnbWVudC9sb2NhbC9kYXRhL21hbmFnZXIvVGFibGVEYXRhTWFuYWdlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...server/starter/helix/HelixInstanceDataManager.java](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3Qtc2VydmVyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zZXJ2ZXIvc3RhcnRlci9oZWxpeC9IZWxpeEluc3RhbmNlRGF0YU1hbmFnZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../pinot/core/data/manager/BaseTableDataManager.java](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvQmFzZVRhYmxlRGF0YU1hbmFnZXIuamF2YQ==) | `71.57% <25.00%> (+71.57%)` | :arrow_up: |
| [...ata/manager/realtime/RealtimeTableDataManager.java](https://app.codecov.io/gh/apache/pinot/pull/11358?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=) | `31.41% <25.00%> (+31.41%)` | :arrow_up: |
... and [1883 files with indirect coverage changes](https://app.codecov.io/gh/apache/pinot/pull/11358/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org