You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "Xuanwo (via GitHub)" <gi...@apache.org> on 2024/11/13 09:13:57 UTC
[PR] feat: Add {stat,list}_has_* to carry the metadata that backend returns [opendal]
Xuanwo opened a new pull request, #5318:
URL: https://github.com/apache/opendal/pull/5318
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of https://github.com/apache/opendal/issues/5314
# Rationale for this change
Allow users to know which metadata will exist in `stat` and `list` before calling.
# What changes are included in this PR?
This PR adds the `{stat,list}_has_*` in capability to carry the metadata that backend returns
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking-changes` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add {stat,list}_has_* to carry the metadata that backend returns [opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #5318:
URL: https://github.com/apache/opendal/pull/5318
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: Add {stat,list}_has_* to carry the metadata that backend returns [opendal]
Posted by "codspeed-hq[bot] (via GitHub)" <gi...@apache.org>.
codspeed-hq[bot] commented on PR #5318:
URL: https://github.com/apache/opendal/pull/5318#issuecomment-2472955252
## [CodSpeed Performance Report](https://codspeed.io/apache/opendal/branches/remove-metakey)
### Merging #5318 will **degrade performances by 21.21%**
<sub>Comparing <code>remove-metakey</code> (7c842aa) with <code>main</code> (41b6f27)</sub>
### Summary
`⚡ 1` improvements
`❌ 12` regressions
`✅ 60` untouched benchmarks
> :warning: _Please fix the performance issues or [acknowledge them on CodSpeed](https://codspeed.io/apache/opendal/branches/remove-metakey)._
### Benchmarks breakdown
| | Benchmark | `main` | `remove-metakey` | Change |
| --- | --------- | ----------------------- | ------------------- | ------ |
| ❌ | `buffer 256 KiB * 32 chunk` | 183.6 ns | 212.8 ns | -13.71% |
| ❌ | `buffer 256 KiB * 4 chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `buffer 4.00 MiB * 32 chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `buffer 4.00 MiB * 4 chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `256 KiB * 1000k chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `256 KiB * 1000k truncate` | 216.7 ns | 275 ns | -21.21% |
| ❌ | `256 KiB * 100k chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `256 KiB * 100k truncate` | 216.7 ns | 275 ns | -21.21% |
| ❌ | `256 KiB * 10k chunk` | 183.6 ns | 212.8 ns | -13.71% |
| ❌ | `256 KiB * 10k truncate` | 216.7 ns | 275 ns | -21.21% |
| ❌ | `256 KiB * 1k chunk` | 154.4 ns | 183.6 ns | -15.89% |
| ❌ | `256 KiB * 1k truncate` | 216.7 ns | 275 ns | -21.21% |
| ⚡ | `concurrent 16` | 321 µs | 289.1 µs | +11.02% |
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org