[jira] [Closed] (COCOON-2360) [2,2] Inconsistent method names

["Francesco Chicchiriccò (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/COCOON-2360?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Francesco Chicchiriccò closed COCOON-2360.
------------------------------------------
    Resolution: Not A Problem

It's not inconsistent, the select() method is on a class named DateSelector, extending AbstractSwitchSelector.
This method's name is also given according to sitemap's standards,

> [2,2] Inconsistent method names
> -------------------------------
>
>                 Key: COCOON-2360
>                 URL: https://issues.apache.org/jira/browse/COCOON-2360
>             Project: Cocoon
>          Issue Type: Improvement
>          Components: Blocks: (Undefined)
>    Affects Versions: 2.2
>            Reporter: KuiLIU
>            Assignee: Francesco Chicchiriccò
>            Priority: Minor
>
> The following method is named as "select".
> "select" is prone to mean that something will be selected.
> But this method actually checks whether the expression is contained or not.
> So, rename it as "contains" should be more clearly and intuitively.
>     public boolean select( String expression ) {
>         return this.set.contains( expression );
>     }



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)