[GitHub] rabbah commented on a change in pull request #2435: Ensure Action Update Creates a Web Action (Review)

[gi...@git.apache.org]

rabbah commented on a change in pull request #2435: Ensure Action Update Creates a Web Action (Review)
URL: https://github.com/apache/incubator-openwhisk/pull/2435#discussion_r124922305
 
 

 ##########
 File path: tools/cli/go-whisk-cli/commands/util.go
 ##########
 @@ -473,6 +473,26 @@ func addKeyValue(key string, value interface{}, keyValueArr whisk.KeyValueArr) (
     return append(keyValueArr, keyValue)
 }
 
+func findKeyValue(keyValueArr whisk.KeyValueArr, key string) (int) {
+    for i := 0; i < len(keyValueArr); i++ {
+        if strings.ToLower(keyValueArr[i].Key) == strings.ToLower(key) {
+            return i
+        }
+    }
+
+    return -1
+}
+
+func appendKeyValueArr(origKeyValueArr whisk.KeyValueArr, appKeyValueArr whisk.KeyValueArr) (whisk.KeyValueArr) {
+    for i := 0; i < len(appKeyValueArr); i++ {
+        if findKeyValue(origKeyValueArr, appKeyValueArr[i].Key) == -1 {
 
 Review comment:
   i didn't follow all the changes closely - we agree the semantics we want are:
   
   ```
   if (new web annotation)
      (prev annotations || []).remove(web annotation).add(new web annotation)
   ```
   
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services