[GitHub] [hive] hmangla98 commented on a change in pull request #2240: HIVE-25086: Create Ranger Deny Policy for replication db in all cases.

[GitBox <gi...@apache.org>]

hmangla98 commented on a change in pull request #2240:
URL: https://github.com/apache/hive/pull/2240#discussion_r625851630



##########
File path: ql/src/java/org/apache/hadoop/hive/ql/exec/repl/ReplLoadTask.java
##########
@@ -160,14 +161,13 @@ public int execute() {
     }
   }
 
-  private boolean shouldLoadAuthorizationMetadata() {
-    return conf.getBoolVar(HiveConf.ConfVars.REPL_INCLUDE_AUTHORIZATION_METADATA);
-  }
-
-  private void initiateAuthorizationLoadTask() throws SemanticException {
+  private void initiateRangerLoadTask() throws SemanticException {

Review comment:
       if REPL_INCLUDE_AUTHORISATION_METADATA is not enabled, rangerLoadRoot would be set to null and RangerLoadTask would not replicate ranger policies if rangerLoadRoot is null. It would only create a deny policy for target db in this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org