You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2017/09/18 02:46:18 UTC

[kudu-CR] data dirs: fix a LOG statement 

Hello Dan Burkert, Andrew Wong (DEPRECATED: please use awong@cloudera.com),

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/8091

to review the following change.

Change subject: data_dirs: fix a LOG statement
......................................................................

data_dirs: fix a LOG statement

This is currently logging like so:

  No directories available to add to 2e4ba76514974786aa2fabda3ac78ae1's directory group (1 dirs total, 0x60400004e490 full, 0 failed). (error 28)

Change-Id: I6fbf51d3c1a5900808146f0d9c62b9b3a193b7d3
---
M src/kudu/fs/data_dirs.cc
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/91/8091/1
-- 
To view, visit http://gerrit.cloudera.org:8080/8091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6fbf51d3c1a5900808146f0d9c62b9b3a193b7d3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong (DEPRECATED: please use awong@cloudera.com) <an...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] data dirs: fix a LOG statement

Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.

Change subject: data_dirs: fix a LOG statement
......................................................................


data_dirs: fix a LOG statement

This is currently logging like so:

  No directories available to add to 2e4ba76514974786aa2fabda3ac78ae1's directory group (1 dirs total, 0x60400004e490 full, 0 failed). (error 28)

Change-Id: I6fbf51d3c1a5900808146f0d9c62b9b3a193b7d3
Reviewed-on: http://gerrit.cloudera.org:8080/8091
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves <da...@gmail.com>
---
M src/kudu/fs/data_dirs.cc
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  David Ribeiro Alves: Looks good to me, approved
  Andrew Wong: Looks good to me, but someone else must approve
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/8091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6fbf51d3c1a5900808146f0d9c62b9b3a193b7d3
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong (DEPRECATED: please use awong@cloudera.com) <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] data dirs: fix a LOG statement

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change.

Change subject: data_dirs: fix a LOG statement
......................................................................


Patch Set 1: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/8091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbf51d3c1a5900808146f0d9c62b9b3a193b7d3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong (DEPRECATED: please use awong@cloudera.com) <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] data dirs: fix a LOG statement

Posted by "David Ribeiro Alves (Code Review)" <ge...@cloudera.org>.
David Ribeiro Alves has posted comments on this change.

Change subject: data_dirs: fix a LOG statement
......................................................................


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/8091
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6fbf51d3c1a5900808146f0d9c62b9b3a193b7d3
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong (DEPRECATED: please use awong@cloudera.com) <an...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <da...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No