You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by "Zhe (Joe) Wang" <jw...@hortonworks.com> on 2016/04/06 00:50:21 UTC
Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat Satellite
option out of experimental
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45781/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-15722
https://issues.apache.org/jira/browse/AMBARI-15722
Repository: ambari
Description
-------
There is an #experimental flag that is used to control RedHat satellite option. That needs to be moved as a regular choice in the UI and exposed. It can be used wherever we show redhat6 urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6
ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 62c3d14
ambari-web/app/templates/wizard/step1.hbs e59b76d
Diff: https://reviews.apache.org/r/45781/diff/
Testing
-------
ambari-web:
25609 tests complete (24 seconds)
154 tests pending
ambari-admin:
Executed 64 of 64 SUCCESS (0.077 secs / 0.299 secs)
Manual testing done.
Thanks,
Zhe (Joe) Wang
Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat
Satellite option out of experimental
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45781/#review127306
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On April 5, 2016, 10:50 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45781/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 10:50 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15722
> https://issues.apache.org/jira/browse/AMBARI-15722
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There is an #experimental flag that is used to control RedHat satellite option. That needs to be moved as a regular choice in the UI and exposed. It can be used wherever we show redhat6 urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6
> ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 62c3d14
> ambari-web/app/templates/wizard/step1.hbs e59b76d
>
> Diff: https://reviews.apache.org/r/45781/diff/
>
>
> Testing
> -------
>
> ambari-web:
> 25609 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.077 secs / 0.299 secs)
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat
Satellite option out of experimental
Posted by Nate Cole <nc...@hortonworks.com>.
> On April 6, 2016, 9:59 a.m., Nate Cole wrote:
> > Is this hooked in anywhere? I don't see any API calls (but that's probably ok for this review). Any ambari-admin view changes?
>
> Zhe (Joe) Wang wrote:
> I thought the requirement for this issue is to expose the RedHat Satellite option, which used to be hidden within experimental flag.
> I assume the feature was complete, due to https://issues.apache.org/jira/browse/AMBARI-15047 .
> And this is just a checkbox to set whether to use satellite. The API call should be triggered at another place, taking the value of that checkbox into account.
> Yes. There is one ambari-admin view, exposing the option at version registration.
> Please let me know if my assumption was wrong.
Just wanted to make sure I understood the scope of this review is all. :) Thanks!
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45781/#review127321
-----------------------------------------------------------
On April 5, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45781/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 6:50 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15722
> https://issues.apache.org/jira/browse/AMBARI-15722
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There is an #experimental flag that is used to control RedHat satellite option. That needs to be moved as a regular choice in the UI and exposed. It can be used wherever we show redhat6 urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6
> ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 62c3d14
> ambari-web/app/templates/wizard/step1.hbs e59b76d
>
> Diff: https://reviews.apache.org/r/45781/diff/
>
>
> Testing
> -------
>
> ambari-web:
> 25609 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.077 secs / 0.299 secs)
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat
Satellite option out of experimental
Posted by "Zhe (Joe) Wang" <jw...@hortonworks.com>.
> On April 6, 2016, 1:59 p.m., Nate Cole wrote:
> > Is this hooked in anywhere? I don't see any API calls (but that's probably ok for this review). Any ambari-admin view changes?
I thought the requirement for this issue is to expose the RedHat Satellite option, which used to be hidden within experimental flag.
I assume the feature was complete, due to https://issues.apache.org/jira/browse/AMBARI-15047 .
And this is just a checkbox to set whether to use satellite. The API call should be triggered at another place, taking the value of that checkbox into account.
Yes. There is one ambari-admin view, exposing the option at version registration.
Please let me know if my assumption was wrong.
- Zhe (Joe)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45781/#review127321
-----------------------------------------------------------
On April 5, 2016, 10:50 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45781/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 10:50 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15722
> https://issues.apache.org/jira/browse/AMBARI-15722
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There is an #experimental flag that is used to control RedHat satellite option. That needs to be moved as a regular choice in the UI and exposed. It can be used wherever we show redhat6 urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6
> ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 62c3d14
> ambari-web/app/templates/wizard/step1.hbs e59b76d
>
> Diff: https://reviews.apache.org/r/45781/diff/
>
>
> Testing
> -------
>
> ambari-web:
> 25609 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.077 secs / 0.299 secs)
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>
Re: Review Request 45781: AMBARI-15722 [Ambari Web] move RedHat
Satellite option out of experimental
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45781/#review127321
-----------------------------------------------------------
Ship it!
Is this hooked in anywhere? I don't see any API calls (but that's probably ok for this review). Any ambari-admin view changes?
- Nate Cole
On April 5, 2016, 6:50 p.m., Zhe (Joe) Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45781/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 6:50 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko, Jaimin Jetly, Nate Cole, Oleg Nechiporenko, Richard Zang, Srimanth Gunturi, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-15722
> https://issues.apache.org/jira/browse/AMBARI-15722
>
>
> Repository: ambari
>
>
> Description
> -------
>
> There is an #experimental flag that is used to control RedHat satellite option. That needs to be moved as a regular choice in the UI and exposed. It can be used wherever we show redhat6 urls, and applicable to redhat6/redhat7. For example, registering repos, etc.
>
>
> Diffs
> -----
>
> ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html 39fabf6
> ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs 62c3d14
> ambari-web/app/templates/wizard/step1.hbs e59b76d
>
> Diff: https://reviews.apache.org/r/45781/diff/
>
>
> Testing
> -------
>
> ambari-web:
> 25609 tests complete (24 seconds)
> 154 tests pending
> ambari-admin:
> Executed 64 of 64 SUCCESS (0.077 secs / 0.299 secs)
> Manual testing done.
>
>
> Thanks,
>
> Zhe (Joe) Wang
>
>