You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2008/09/19 18:40:09 UTC

Re: svn commit: r33196 - trunk/www

> +   * trunk/ (svn:ignore): Ignore build.

Since 'build' is a directory name, it should be put in single quotes.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Blair Zajac <bl...@orcaware.com>.
Daniel Shahaf wrote:
> Blair Zajac wrote on Fri, 19 Sep 2008 at 13:06 -0700:
>> Karl Fogel wrote:
>>> Daniel Shahaf <d....@daniel.shahaf.name> writes:
>>>>> +   * trunk/ (svn:ignore): Ignore build.
>>>> Since 'build' is a directory name, it should be put in single quotes.
>>> Aiiiiiyaaaaa, Greg Stein is right :-).
>>>
>>> (True, there is some potential for confusion in this case, since "build"
>>> is otherwise a noun that refers to an output of a compilation,
>>> but... Let's not go overboard on this stuff.)
>> In this case I think it would be better to just modify the log message
>> oneself instead of sending a note to the list which asking the person modify
>> it, to reduce the amount of email and time to fix something this small.
>>
>> Blair
> 
> If it *were* a commit log message, then I would leave it alone.  I commented
> only because it was added to HACKING.  And I commented on list because my
> default is not to change HACKING without discussion.  (Defaults are not
> always good :) )

Argh, that's right.  No more email about this issue from me :)

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Jeremy Whitlock <jc...@gmail.com>.
> Well, I think this sort of thing falls under "Try to write things in
> such a way as to avoid potential misunderstanding."  IOW, read the text
> back to yourself, as though you were not a Subversion expert, and see if
> it means exactly what you want it to mean.  I'm not sure we need a
> guideline beyond that.

After talking with Daniel, I got the picture.  Thanks for bearing with me.

> Thanks for tweaking it.

No problem.

-- 
Take care,

Jeremy Whitlock
http://www.thoughtspark.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Karl Fogel <kf...@red-bean.com>.
"Jeremy Whitlock" <jc...@gmail.com> writes:
> As of r33197, this is fixed.  On a side, note, can someone tell me
> where this is documented?  I cannot find this mentioned in the
> previous Hacker's Guide or the "Version Control with Subversion" book.

Well, I think this sort of thing falls under "Try to write things in
such a way as to avoid potential misunderstanding."  IOW, read the text
back to yourself, as though you were not a Subversion expert, and see if
it means exactly what you want it to mean.  I'm not sure we need a
guideline beyond that.

Thanks for tweaking it.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Jeremy Whitlock <jc...@gmail.com>.
As of r33197, this is fixed.  On a side, note, can someone tell me
where this is documented?  I cannot find this mentioned in the
previous Hacker's Guide or the "Version Control with Subversion" book.

-- 
Take care,

Jeremy Whitlock
http://www.thoughtspark.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Blair Zajac wrote on Fri, 19 Sep 2008 at 13:06 -0700:
> Karl Fogel wrote:
> > Daniel Shahaf <d....@daniel.shahaf.name> writes:
> > > > +   * trunk/ (svn:ignore): Ignore build.
> > > Since 'build' is a directory name, it should be put in single quotes.
> > 
> > Aiiiiiyaaaaa, Greg Stein is right :-).
> > 
> > (True, there is some potential for confusion in this case, since "build"
> > is otherwise a noun that refers to an output of a compilation,
> > but... Let's not go overboard on this stuff.)
> 
> In this case I think it would be better to just modify the log message
> oneself instead of sending a note to the list which asking the person modify
> it, to reduce the amount of email and time to fix something this small.
> 
> Blair

If it *were* a commit log message, then I would leave it alone.  I commented
only because it was added to HACKING.  And I commented on list because my
default is not to change HACKING without discussion.  (Defaults are not
always good :) )

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Blair Zajac <bl...@orcaware.com>.
Karl Fogel wrote:
> Daniel Shahaf <d....@daniel.shahaf.name> writes:
>>> +   * trunk/ (svn:ignore): Ignore build.
>> Since 'build' is a directory name, it should be put in single quotes.
> 
> Aiiiiiyaaaaa, Greg Stein is right :-).
> 
> (True, there is some potential for confusion in this case, since "build"
> is otherwise a noun that refers to an output of a compilation,
> but... Let's not go overboard on this stuff.)

In this case I think it would be better to just modify the log message oneself 
instead of sending a note to the list which asking the person modify it, to 
reduce the amount of email and time to fix something this small.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: svn commit: r33196 - trunk/www

Posted by Karl Fogel <kf...@red-bean.com>.
Daniel Shahaf <d....@daniel.shahaf.name> writes:
>> +   * trunk/ (svn:ignore): Ignore build.
>
> Since 'build' is a directory name, it should be put in single quotes.

Aiiiiiyaaaaa, Greg Stein is right :-).

(True, there is some potential for confusion in this case, since "build"
is otherwise a noun that refers to an output of a compilation,
but... Let's not go overboard on this stuff.)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org