[GitHub] [superset] villebro commented on pull request #16525: perf(dashboard): reduce rerenders of DragDroppable

[GitBox <gi...@apache.org>]

villebro commented on pull request #16525:
URL: https://github.com/apache/superset/pull/16525#issuecomment-910609547


   > @villebro I don't see any JSON.stringify in the files modified by this PR. Do you mean any specific place, or using JSON.stringify in deps array in general? I agree that we should limit using that as much as possible - maybe we can do that gradually as a side effect of other future PRs?
   
   I merely meant that it was difficult for me to assess where it was sufficient to pass the object as-is in the deps array vs running it through `JSON.stringify`. I agree we should refrain fron stringifying whenever we can, and I also agree we should keep removal of stringification to future PRs. So no action needed here, just voicing my concerns/ignorance here 🙂


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org