[GitHub] tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] Port JobManagerFailsITCase to new code base

[GitBox <gi...@apache.org>]

tillrohrmann commented on a change in pull request #6841: [FLINK-10405] [tests] Port JobManagerFailsITCase to new code base
URL: https://github.com/apache/flink/pull/6841#discussion_r225087527
 
 

 ##########
 File path: flink-tests/src/test/java/org/apache/flink/test/recovery/JobManagerHAProcessFailureRecoveryITCase.java
 ##########
 @@ -325,6 +325,21 @@ public void run() {
 			dispatcherProcesses[1] = new DispatcherProcess(1, config);
 			dispatcherProcesses[1].startProcess();
 
+			// get new dispatcher gateway
+			leaderListener.waitForNewLeader(deadline.timeLeft().toMillis());
+
+			leaderAddress = leaderListener.getAddress();
+			leaderId = leaderListener.getLeaderSessionID();
+
+			final CompletableFuture<DispatcherGateway> newDispatcherGatewayFuture = rpcService.connect(
+				leaderAddress,
+				DispatcherId.fromUuid(leaderId),
+				DispatcherGateway.class);
+			final DispatcherGateway newDispatcherGateway = newDispatcherGatewayFuture.get();
+
+			// Wait for all task managers to connect to the new leading job manager
+			waitForTaskManagers(numberOfTaskManagers, newDispatcherGateway, deadline.timeLeft());
 
 Review comment:
   Why do we have to add this code block? Shouldn't this implicitly be asserted if the jobs finishes successfully?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services