You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by pavan kumar kolamuri <pa...@gmail.com> on 2015/12/18 14:00:57 UTC
Review Request 41545: Cascading delete in case of Native Scheduler
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1640
https://issues.apache.org/jira/browse/FALCON-1640
Repository: falcon-git
Description
-------
Whenever entity is deleted corresponding instances should be deleted in statestore.
Diffs
-----
common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
Diff: https://reviews.apache.org/r/41545/diff/
Testing
-------
Unit testing with Derby and Manual testing with my-sql done.
Thanks,
pavan kumar kolamuri
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Dec. 23, 2015, 9:54 a.m., Ajay Yadava wrote:
> > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, line 390
> > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line390>
> >
> > nit: order is actual first, expected second. Otherwise it will give confusing error message in case of failures.
Thanks will fix
> On Dec. 23, 2015, 9:54 a.m., Ajay Yadava wrote:
> > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, line 398
> > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line398>
> >
> > nit: order is actual first, expected second. Otherwise it will give confusing error message in case of failures.
Will fix same here
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111763
-----------------------------------------------------------
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111763
-----------------------------------------------------------
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java (line 390)
<https://reviews.apache.org/r/41545/#comment172037>
nit: order is actual first, expected second. Otherwise it will give confusing error message in case of failures.
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java (line 398)
<https://reviews.apache.org/r/41545/#comment172036>
nit: order is actual first, expected second. Otherwise it will give confusing error message in case of failures.
- Ajay Yadava
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Dec. 23, 2015, 9:33 a.m., Pallavi Rao wrote:
> > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, line 425
> > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line425>
> >
> > Shouldn't delete entities and not instances?
>
> pavan kumar kolamuri wrote:
> Once instances are deleted entities will be deleted with Cascading delete, Thats why removed this.
>
> Pallavi Rao wrote:
> The constraint should be other way around. When an entity is deleted, all its instances must get deleted.
Yes My bad will fix
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111756
-----------------------------------------------------------
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Dec. 23, 2015, 9:33 a.m., Pallavi Rao wrote:
> > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, line 425
> > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line425>
> >
> > Shouldn't delete entities and not instances?
>
> pavan kumar kolamuri wrote:
> Once instances are deleted entities will be deleted with Cascading delete, Thats why removed this.
The constraint should be other way around. When an entity is deleted, all its instances must get deleted.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111756
-----------------------------------------------------------
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
> On Dec. 23, 2015, 9:33 a.m., Pallavi Rao wrote:
> > scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java, line 425
> > <https://reviews.apache.org/r/41545/diff/1/?file=1170861#file1170861line425>
> >
> > Shouldn't delete entities and not instances?
Once instances are deleted entities will be deleted with Cascading delete, Thats why removed this.
- pavan kumar
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111756
-----------------------------------------------------------
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111756
-----------------------------------------------------------
Ship it!
Once you address the minor comment, the patch is good to go.
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java (line 424)
<https://reviews.apache.org/r/41545/#comment172020>
Shouldn't delete entities and not instances?
- Pallavi Rao
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111856
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Dec. 24, 2015, 12:03 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2015, 12:03 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 305b398
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java 151c2c2
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 34156c0
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by pavan kumar kolamuri <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/
-----------------------------------------------------------
(Updated Dec. 24, 2015, 12:03 p.m.)
Review request for Falcon.
Changes
-------
Addressed comments
Bugs: FALCON-1640
https://issues.apache.org/jira/browse/FALCON-1640
Repository: falcon-git
Description
-------
Whenever entity is deleted corresponding instances should be deleted in statestore.
Diffs (updated)
-----
common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 305b398
scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java 151c2c2
scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 34156c0
Diff: https://reviews.apache.org/r/41545/diff/
Testing
-------
Unit testing with Derby and Manual testing with my-sql done.
Thanks,
pavan kumar kolamuri
Re: Review Request 41545: Cascading delete in case of Native Scheduler
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41545/#review111766
-----------------------------------------------------------
Can you please also document the behavior of delete, what all will be deleted, why it is required etc. in deleteEntity method of state store interface. This will be extremely helpful for others to understand the code and it's expected behaviour.
- Ajay Yadava
On Dec. 18, 2015, 1 p.m., pavan kumar kolamuri wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41545/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 1 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1640
> https://issues.apache.org/jira/browse/FALCON-1640
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Whenever entity is deleted corresponding instances should be deleted in statestore.
>
>
> Diffs
> -----
>
> common/src/test/java/org/apache/falcon/entity/AbstractTestBase.java a6d607b
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/EntityBean.java 03ada39
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/InstanceBean.java 0e3dfa9
> scheduler/src/main/java/org/apache/falcon/state/store/jdbc/JDBCStateStore.java b2f8e80
> scheduler/src/test/java/org/apache/falcon/state/service/store/TestJDBCStateStore.java 6d5bd49
>
> Diff: https://reviews.apache.org/r/41545/diff/
>
>
> Testing
> -------
>
> Unit testing with Derby and Manual testing with my-sql done.
>
>
> Thanks,
>
> pavan kumar kolamuri
>
>