[GitHub] [kafka] ableegoldman commented on a change in pull request #9489: MINOR: demote "Committing task offsets" log to DEBUG

[GitBox <gi...@apache.org>]

ableegoldman commented on a change in pull request #9489:
URL: https://github.com/apache/kafka/pull/9489#discussion_r520970972



##########
File path: streams/src/main/java/org/apache/kafka/streams/processor/internals/StreamThread.java
##########
@@ -703,6 +703,14 @@ void runOnce() {
             // we record the ratio out of the while loop so that the accumulated latency spans over
             // multiple iterations with reasonably large max.num.records and hence is less vulnerable to outliers
             taskManager.recordTaskProcessRatio(totalProcessLatency, now);
+
+            // Only log this when we actually processed some records to avoid flooding INFO-level logs when there are
+            // no records on the input topics
+            if (totalProcessed > 0) {
+                log.info("Finished processing {} records, going to poll again", totalProcessed);
+            } else {
+                log.debug("Processed zero records, going to poll again");

Review comment:
       Reworked it a bit, lmk what you think




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org