You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/09/04 14:14:22 UTC
[GitHub] [shardingsphere] everly-gif opened a new pull request, #20774: Enhance support for `ALTER TABLE` and `ALTER VIEW` in PostgreSQL
everly-gif opened a new pull request, #20774:
URL: https://github.com/apache/shardingsphere/pull/20774
Ref #17848
Sub-issue of #14015
Changes proposed in this pull request:
- `ALTER TABLE` was already partially supported, this
PR enhances that support.
- `ALTER VIEW` was already properly supported, this PR
adds additional test case.
✅ Builds locally
Finishes GSOC Tasks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #20774: Enhance support for `ALTER TABLE` and `ALTER VIEW` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #20774:
URL: https://github.com/apache/shardingsphere/pull/20774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #20774: Enhance support for `ALTER TABLE` and `ALTER VIEW` in PostgreSQL
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #20774:
URL: https://github.com/apache/shardingsphere/pull/20774#issuecomment-1236358826
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/20774?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20774](https://codecov.io/gh/apache/shardingsphere/pull/20774?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b742487) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aaa6f8777b0080ed3d853e33b8c725af54fb304a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aaa6f87) will **increase** coverage by `0.05%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #20774 +/- ##
============================================
+ Coverage 61.24% 61.30% +0.05%
- Complexity 2417 2419 +2
============================================
Files 3973 3983 +10
Lines 55183 55231 +48
Branches 9365 9373 +8
============================================
+ Hits 33798 33859 +61
+ Misses 18506 18490 -16
- Partials 2879 2882 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/20774?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...xception/ShardingSphereConfigurationException.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9jb25maWcvZXhjZXB0aW9uL1NoYXJkaW5nU3BoZXJlQ29uZmlndXJhdGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...or/statement/impl/SQL92DDLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1zcWw5Mi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9zcWw5Mi92aXNpdG9yL3N0YXRlbWVudC9pbXBsL1NRTDkyRERMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `51.85% <0.00%> (-8.65%)` | :arrow_down: |
| [...apache/shardingsphere/sharding/rule/TableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9UYWJsZVJ1bGUuamF2YQ==) | `83.15% <0.00%> (-0.18%)` | :arrow_down: |
| [...che/shardingsphere/sharding/rule/ShardingRule.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9TaGFyZGluZ1J1bGUuamF2YQ==) | `84.69% <0.00%> (ø)` | |
| [...shardingsphere/sharding/rule/BindingTableRule.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcnVsZS9CaW5kaW5nVGFibGVSdWxlLmphdmE=) | `94.11% <0.00%> (ø)` | |
| [...gsphere/dialect/exception/SQLDialectException.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24vc2hhcmRpbmdzcGhlcmUtZGlhbGVjdC1leGNlcHRpb24tY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZGlhbGVjdC9leGNlcHRpb24vU1FMRGlhbGVjdEV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ase/schema/decorator/model/ShardingSphereView.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9zY2hlbWEvZGVjb3JhdG9yL21vZGVsL1NoYXJkaW5nU3BoZXJlVmlldy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ine/type/unicast/ShardingUnicastRoutingEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmcvc2hhcmRpbmdzcGhlcmUtc2hhcmRpbmctY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc2hhcmRpbmcvcm91dGUvZW5naW5lL3R5cGUvdW5pY2FzdC9TaGFyZGluZ1VuaWNhc3RSb3V0aW5nRW5naW5lLmphdmE=) | `95.45% <0.00%> (ø)` | |
| [...util/exception/sql/ShardingSphereSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vc3FsL1NoYXJkaW5nU3BoZXJlU1FMRXhjZXB0aW9uLmphdmE=) | | |
| [.../infra/util/exception/sql/UnknownSQLException.java](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtdXRpbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvaW5mcmEvdXRpbC9leGNlcHRpb24vc3FsL1Vua25vd25TUUxFeGNlcHRpb24uamF2YQ==) | | |
| ... and [27 more](https://codecov.io/gh/apache/shardingsphere/pull/20774/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org