You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2018/08/06 08:07:14 UTC
Review Request 68219: Updated `volume/secret` isolator to honor
volume mode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
-----------------------------------------------------------
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/secret` isolator to honor volume mode.
Diffs
-----
src/slave/containerizer/mesos/isolators/volume/secret.cpp 663aafc7173667f8f78b26bdc824a3ab2e04ed25
Diff: https://reviews.apache.org/r/68219/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68219: Updated `volume/secret` isolator to honor
volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
-----------------------------------------------------------
(Updated Aug. 14, 2018, 2:29 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Addressed review comments.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/secret` isolator to honor volume mode.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/secret.cpp 663aafc7173667f8f78b26bdc824a3ab2e04ed25
Diff: https://reviews.apache.org/r/68219/diff/3/
Changes: https://reviews.apache.org/r/68219/diff/2-3/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 68219: Updated `volume/secret` isolator to honor
volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
> On Aug. 14, 2018, 7:30 a.m., Gilbert Song wrote:
> > src/slave/containerizer/mesos/isolators/volume/secret.cpp
> > Lines 287 (patched)
> > <https://reviews.apache.org/r/68219/diff/2/?file=2069915#file2069915line287>
> >
> > Why not the same order as previous patches? I guess it does not hurt
Agree, let me make it the same order as the previous patches.
- Qian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/#review207185
-----------------------------------------------------------
On Aug. 7, 2018, 10:22 p.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68219/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 10:22 p.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `volume/secret` isolator to honor volume mode.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/secret.cpp 663aafc7173667f8f78b26bdc824a3ab2e04ed25
>
>
> Diff: https://reviews.apache.org/r/68219/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68219: Updated `volume/secret` isolator to honor
volume mode.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/#review207185
-----------------------------------------------------------
Ship it!
src/slave/containerizer/mesos/isolators/volume/secret.cpp
Lines 287 (patched)
<https://reviews.apache.org/r/68219/#comment290479>
Why not the same order as previous patches? I guess it does not hurt
- Gilbert Song
On Aug. 7, 2018, 7:22 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68219/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2018, 7:22 a.m.)
>
>
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
>
>
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated `volume/secret` isolator to honor volume mode.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/volume/secret.cpp 663aafc7173667f8f78b26bdc824a3ab2e04ed25
>
>
> Diff: https://reviews.apache.org/r/68219/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 68219: Updated `volume/secret` isolator to honor
volume mode.
Posted by Qian Zhang <zh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68219/
-----------------------------------------------------------
(Updated Aug. 7, 2018, 10:22 p.m.)
Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
Changes
-------
Rebased.
Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814
Repository: mesos
Description
-------
Updated `volume/secret` isolator to honor volume mode.
Diffs (updated)
-----
src/slave/containerizer/mesos/isolators/volume/secret.cpp 663aafc7173667f8f78b26bdc824a3ab2e04ed25
Diff: https://reviews.apache.org/r/68219/diff/2/
Changes: https://reviews.apache.org/r/68219/diff/1-2/
Testing
-------
Thanks,
Qian Zhang