You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "shy-share (via GitHub)" <gi...@apache.org> on 2023/05/29 01:24:16 UTC
[GitHub] [pulsar-site] shy-share opened a new pull request, #591: In order to ensure that the api documentation is up-to-date in search…
shy-share opened a new pull request, #591:
URL: https://github.com/apache/pulsar-site/pull/591
<!--
### Contribution Checklist
- PR title format should be *[type][component] summary*. For details, see *[Guideline - Pulsar PR Naming Convention](https://pulsar.apache.org/contribute/develop-semantic-title/)*.
-->
<!-- Either this PR adds a doc for a code PR, -->
<!-- or fixes a doc issue -->
This PR fixes https://github.com/apache/pulsar/pull/20390
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `./preview.sh` at root path) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [ ] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] shy-share commented on pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "shy-share (via GitHub)" <gi...@apache.org>.
shy-share commented on PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#issuecomment-1614053583
#623 has solved this problem, so close this pr
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] tisonkun commented on a diff in pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#discussion_r1221118072
##########
static/robots.txt:
##########
@@ -1 +1,5 @@
Sitemap: https://pulsar.apache.org/sitemap.xml
+User-agent: *
+Allow: /
+Disallow: /api/
Review Comment:
We should exclude legacy versions only. Maintained versions should be still indexed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] shy-share closed pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "shy-share (via GitHub)" <gi...@apache.org>.
shy-share closed pull request #591: In order to ensure that the api documentation is up-to-date in search…
URL: https://github.com/apache/pulsar-site/pull/591
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] shy-share commented on pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "shy-share (via GitHub)" <gi...@apache.org>.
shy-share commented on PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#issuecomment-1566376655
> 1. Why do you delete the sitemap entry?
> 2. Allow and Disallow seems reversed.
@tisonkun

--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] shy-share commented on pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "shy-share (via GitHub)" <gi...@apache.org>.
shy-share commented on PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#issuecomment-1566372497
> 1. Why do you delete the sitemap entry?
> 2. Allow and Disallow seems reversed.
I have already edited it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] shy-share commented on pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "shy-share (via GitHub)" <gi...@apache.org>.
shy-share commented on PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#issuecomment-1566389871
> The goal is that we want legacy API docs not to be crawled. Please check the motivation and target,
Well, I understand the meaning is just the opposite
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] shy-share commented on pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "shy-share (via GitHub)" <gi...@apache.org>.
shy-share commented on PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#issuecomment-1566356402
@tisonkun cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-site] Anonymitaet commented on pull request #591: In order to ensure that the api documentation is up-to-date in search…
Posted by "Anonymitaet (via GitHub)" <gi...@apache.org>.
Anonymitaet commented on PR #591:
URL: https://github.com/apache/pulsar-site/pull/591#issuecomment-1573046228
> Well, I understand the meaning is just the opposite
We want to show the latest stable API doc version (e.g., 3.0.x) instead of legacy ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org