[jira] [Comment Edited] (OFBIZ-9551) Convert createMarketingCampaignRole service to entity-auto service

["Deepak Dixit (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-9551?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16816067#comment-16816067 ] 

Deepak Dixit edited comment on OFBIZ-9551 at 4/12/19 8:09 AM:
--------------------------------------------------------------

Patch looks good to me, One minor improvement can be done, we can use marketingPermissionService instead of required-permissions.
{code}
<permission-service service-name="marketingPermissionService" main-action="CREATE"/>
{code}
I'll commit patch with suggested changes. 


was (Author: deepak.dixit):
Patch looks good to me, One minor improment can be done, we can use marketingPermissionService instead required-permissions.

<permission-service service-name="marketingPermissionService" main-action="CREATE"/>

I'll commit patch with suggested changes. 

> Convert createMarketingCampaignRole service to entity-auto service
> ------------------------------------------------------------------
>
>                 Key: OFBIZ-9551
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9551
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: marketing
>    Affects Versions: Trunk
>            Reporter: Suraj Khurana
>            Assignee: Deepak Dixit
>            Priority: Major
>         Attachments: OFBIZ-9551-simple.patch, OFBIZ-9551.patch
>
>
> Currently, this service is having some permission related code at CampaignServices.xml which is of no use and can be deleted, we can move that code to a separate permission check service that can be used elsewhere as well.
> Also, this pattern is currently used in other areas like Party etc



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)