You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/07/04 05:44:12 UTC
[GitHub] [incubator-eventmesh] mytang0 opened a new pull request, #990: [ISSUE #389] Implement redis connector
mytang0 opened a new pull request, #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990
Impl ISSUE #389
### Motivation
*Implement the redis connector plugin*
### Modifications
### Documentation
- Does this pull request introduce a new feature? (yes)
- If yes, how is the feature documented? (not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 commented on pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
mytang0 commented on PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990#issuecomment-1179888789
@ruanwenjun @kirinzhu Can you help with the review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] kirinzhu commented on a diff in pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
kirinzhu commented on code in PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990#discussion_r918708253
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshStartup.java:
##########
@@ -35,6 +36,7 @@ public static void main(String[] args) throws Exception {
ConfigurationWrapper configurationWrapper =
new ConfigurationWrapper(EventMeshConstants.EVENTMESH_CONF_HOME,
EventMeshConstants.EVENTMESH_CONF_FILE, false);
+ ConfigurationContextUtil.setBaseConfigurationWrapper(configurationWrapper);
Review Comment:
Sorry, I am confused why you want to add this line. Could you please not modify eventmesh-runtime? Generally, eventmesh-runtime is not encouraged to be changed.
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshStartup.java:
##########
@@ -35,6 +36,7 @@ public static void main(String[] args) throws Exception {
ConfigurationWrapper configurationWrapper =
new ConfigurationWrapper(EventMeshConstants.EVENTMESH_CONF_HOME,
EventMeshConstants.EVENTMESH_CONF_FILE, false);
+ ConfigurationContextUtil.setBaseConfigurationWrapper(configurationWrapper);
Review Comment:
Please refer to what eventmesh-connector-rocketmq looks like, so that we could merge your branch into master branch in the further future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 commented on a diff in pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
mytang0 commented on code in PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990#discussion_r919585470
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/boot/EventMeshStartup.java:
##########
@@ -35,6 +36,7 @@ public static void main(String[] args) throws Exception {
ConfigurationWrapper configurationWrapper =
new ConfigurationWrapper(EventMeshConstants.EVENTMESH_CONF_HOME,
EventMeshConstants.EVENTMESH_CONF_FILE, false);
+ ConfigurationContextUtil.setBaseConfigurationWrapper(configurationWrapper);
Review Comment:
> Sorry, I am confused why you want to add this line. Could you please not modify eventmesh-runtime? Generally, eventmesh-runtime is not encouraged to be changed.
Because we use the configuration center for unified management of configuration information, we hope to have a unified configuration reference, instead of piecemeal configuration like eventmesh-connector-rocketmq. It is really hard to understand from the perspective of redis-connector. Therefore, I will remove this part of the function first, and then raise an issue to solve the configuration problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] mytang0 commented on pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
mytang0 commented on PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990#issuecomment-1179871133
Can someone review the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
xwm1992 merged PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov[bot] commented on pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990#issuecomment-1173411660
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/990?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#990](https://codecov.io/gh/apache/incubator-eventmesh/pull/990?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (20e5c79) into [redis-connector](https://codecov.io/gh/apache/incubator-eventmesh/commit/dab10863a82a1828ea2e44b164086a1427abd8a3?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dab1086) will **increase** coverage by `0.41%`.
> The diff coverage is `55.60%`.
> :exclamation: Current head 20e5c79 differs from pull request most recent head cf393a4. Consider uploading reports for the commit cf393a4 to get more accurate results
```diff
@@ Coverage Diff @@
## redis-connector #990 +/- ##
====================================================
+ Coverage 8.42% 8.84% +0.41%
- Complexity 534 570 +36
====================================================
Files 362 371 +9
Lines 23228 23468 +240
Branches 2546 2555 +9
====================================================
+ Hits 1958 2075 +117
- Misses 21118 21220 +102
- Partials 152 173 +21
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/990?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...in/java/org/apache/eventmesh/common/Constants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9Db25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...e/eventmesh/common/config/CommonConfiguration.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29tbW9uQ29uZmlndXJhdGlvbi5qYXZh) | `85.36% <0.00%> (-2.29%)` | :arrow_down: |
| [.../eventmesh/common/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `41.02% <0.00%> (-2.22%)` | :arrow_down: |
| [...entmesh/common/utils/ConfigurationContextUtil.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi91dGlscy9Db25maWd1cmF0aW9uQ29udGV4dFV0aWwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...redis/connector/RedisConnectorResourceService.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9jb25uZWN0b3IvUmVkaXNDb25uZWN0b3JSZXNvdXJjZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...mesh/connector/redis/constants/RedisConstants.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9jb25zdGFudHMvUmVkaXNDb25zdGFudHMuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...pache/eventmesh/runtime/boot/EventMeshStartup.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvRXZlbnRNZXNoU3RhcnR1cC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...entmesh/connector/redis/client/RedissonClient.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9jbGllbnQvUmVkaXNzb25DbGllbnQuamF2YQ==) | `39.34% <39.34%> (ø)` | |
| [...ntmesh/connector/redis/producer/RedisProducer.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9wcm9kdWNlci9SZWRpc1Byb2R1Y2VyLmphdmE=) | `52.17% <52.17%> (ø)` | |
| [...h/connector/redis/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbm5lY3Rvci1wbHVnaW4vZXZlbnRtZXNoLWNvbm5lY3Rvci1yZWRpcy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2Nvbm5lY3Rvci9yZWRpcy9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `56.00% <56.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/incubator-eventmesh/pull/990/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/990?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/990?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dab1086...cf393a4](https://codecov.io/gh/apache/incubator-eventmesh/pull/990?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] kirinzhu commented on pull request #990: [ISSUE #389] Implement redis connector
Posted by GitBox <gi...@apache.org>.
kirinzhu commented on PR #990:
URL: https://github.com/apache/incubator-eventmesh/pull/990#issuecomment-1180127206
> @ruanwenjun @kirinzhu Can you help with the review?
Yep, working on it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org