[GitHub] [superset] villebro edited a comment on pull request #12662: feat(cross-filters): add cross filters

[GitBox <gi...@apache.org>]

villebro edited a comment on pull request #12662:
URL: https://github.com/apache/superset/pull/12662#issuecomment-767517823


   > I wonder in terms of actual UX, is a separate `filter_select` viz type actually what we want?
   > 
   > I remember when we [talked about cross-filtering before](https://github.com/apache/superset/pull/9593#discussion_r411927471), the expectation was that clicking on elements in a chart itself will update the filters (be it a table chart cell, or the legend in a line chart). Each chart will have a `cross_filter` config value and will emit filter events accordingly.
   > 
   > Is this still the ultimate goal?
   
   I feel the ultimate goal is to support cross filtering in all charts where it makes sense. But opt-in of course; clicking an item on a chart should only cause cross filtering if explicitly enabled. The following obvious charts come to mind:
   - table chart: filter only selected rows
   - pivot table: filter only selected rows/columns/cells
   - pie chart: same: filter only selected slices
   - bar chart: filter only selected bars
   - timeseries chart: filter only selected time range (x-axis) or selected series.
   
   etc. Even in the presence of more advanced charts with cross-filtering functionality, the simple select filter used in native filters may very well be something that end users want to place on the dashboard like a chart, especially when there will be lots of selects on a dashboard. To reduce confusion, it would be a good idea to keep these native filter charts separate from regular charts in the chart type selector, e.g. in a separate tab ("charts" vs "native filters").


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org