You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2020/04/18 14:38:59 UTC
[GitHub] [netbeans] lkishalmi opened a new pull request #2088: Revert
"[NETBEANS-4039] Added SPI for Preferred Color Profile Changes"
lkishalmi opened a new pull request #2088: Revert "[NETBEANS-4039] Added SPI for Preferred Color Profile Changes"
URL: https://github.com/apache/netbeans/pull/2088
Reverts apache/netbeans#2039, as the introduced new dependency made some unit-test load for ever waiting on the UI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] jlahoda commented on a change in pull request #2088:
Revert "[NETBEANS-4039] Added SPI for Preferred Color Profile Changes"
Posted by GitBox <gi...@apache.org>.
jlahoda commented on a change in pull request #2088: Revert "[NETBEANS-4039] Added SPI for Preferred Color Profile Changes"
URL: https://github.com/apache/netbeans/pull/2088#discussion_r410709386
##########
File path: platform/core.windows/manifest.mf
##########
@@ -6,5 +6,5 @@ OpenIDE-Module-Provides: org.netbeans.core.WindowSystem, org.openide.windows.Win
OpenIDE-Module-Recommends: org.netbeans.core.windows.nativeaccess.NativeWindowSystem
AutoUpdate-Show-In-Client: false
AutoUpdate-Essential-Module: true
-OpenIDE-Module-Specification-Version: 2.92
+OpenIDE-Module-Specification-Version: 2.91
Review comment:
I guess I would suggest to actually increase the spec version (so that the spec versions are monotonically increasing). I.e.:
```suggestion
OpenIDE-Module-Specification-Version: 2.93
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists