[GitHub] [spark] hvanhovell commented on a change in pull request #32786: [SPARK-35296][SQL] Allow Dataset.observe to work even if CollectMetricsExec in a task handles multiple partitions.

[GitBox <gi...@apache.org>]

hvanhovell commented on a change in pull request #32786:
URL: https://github.com/apache/spark/pull/32786#discussion_r646974983



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/AggregatingAccumulator.scala
##########
@@ -148,6 +148,14 @@ class AggregatingAccumulator private(
   }
 
   override def merge(other: AccumulatorV2[InternalRow, InternalRow]): Unit = withSQLConf(()) {
+    mergeInternal(other)
+  }
+
+  /**
+   * Actual code for merge. This function is not intended to be called directly from executor side.
+   * One exception is `addState`.
+   */
+  private def mergeInternal(other: AccumulatorV2[InternalRow, InternalRow]): Unit = {

Review comment:
       Why do we need to make a difference between merge and mergeInternal?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org