You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by "PurelyApplied (GitHub)" <gi...@apache.org> on 2018/10/26 22:57:11 UTC
[GitHub] [geode] PurelyApplied opened pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
…-driver modules.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Sounds good!
For what it's worth, I'm hoping to finish up a `spotlessGradle` ruleset that will enforce grouping in dependency declarations. It has a bit of confusion around comments, though. But hopefully a PR for it will be up soon.
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
Lets fix the ordering of configurations, and put project dependencies before 3rd party
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
I agree, and I don't know. I've just been following the pattern of where dependencies are consumed elsewhere, and `spring-shell` has these excludes where it is consumed in other modules. The Nebula linter identified `spring-shell` as a missing dependency, so I went with it, but brought the exclusions in myself.
Although, It'll be a bit cleaner when the exclusions can be declared at the project or module level, once Gradle5 releases and we migrate to it.
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
Wait, I'm confusing myself on how I should parse your comment...
Which do you find preferable? Configuration > Project > Alphabetical, or Project > Configuration > Alphabetical? E.g.,
Option A:
```
compile project('A')
testCompile project('B')
compile 'other-thing'
testCompile 'other-other-thing'
```
Option B:
```
compile project('A')
compile 'other-thing'
testCompile project('B')
testCompile 'other-other-thing'
```
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied closed pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] PurelyApplied commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "PurelyApplied (GitHub)" <gi...@apache.org>.
I'll integrate that into my work-in-progress for a Gradle Spotless, then!
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
Wow, that's a lot of excludes. Is there a smaller module from Spring that we could import instead of this monolith (minus things) approach?
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org
[GitHub] [geode] rhoughton-pivot commented on pull request #2738: GEODE-5947: Make dependencies explicit in connectors and experimental…
Posted by "rhoughton-pivot (GitHub)" <gi...@apache.org>.
Option B
[ Full content available at: https://github.com/apache/geode/pull/2738 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org