You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "zhengruifeng (via GitHub)" <gi...@apache.org> on 2026/10/20 09:38:28 UTC
[PR] [SPARK-60384][BUILD] Check binary compatibility against Spark 4.2.0 [spark]
zhengruifeng opened a new pull request, #59635:
URL: https://github.com/apache/spark/pull/59635
### What changes were proposed in this pull request?
Use Spark 4.2.0 as the previous artifact version for MiMa, and switch `GenerateMIMAIgnore`'s class finder from ASM8 to ASM9.
Add four narrow MiMa exclusions for the private `ProxyRedirectHandler.MutableFieldsWrapper` and `ResponseWrapper` implementation members whose Jetty types are shaded in the published 4.2.0 artifact.
### Why are the changes needed?
The 4.0.0 baseline does not comprehensively check released signatures introduced in Spark 4.1 and 4.2. Updating the baseline brings those APIs into the configured binary-compatibility checks.
The 4.2.0 artifacts also contain sealed interfaces. ASM8 cannot visit their `PermittedSubclasses` attribute, so the exclusion scanner must request ASM9.
The first run against 4.2.0 found only four Jetty shading differences in explicitly private nested wrapper classes. The added exclusions are limited to those private implementation details; existing compatibility exclusions are retained.
Please also backport to `branch-4.x` and `branch-4.3`.
### Does this PR introduce _any_ user-facing change?
No runtime API change. Build-time binary compatibility checks now compare against Spark 4.2.0.
### How was this patch tested?
Ran the standard `dev/mima` pipeline with Java 17. After adding the four private Jetty-wrapper exclusions, the pipeline completed successfully, including generation of private API exclusions and binary-compatibility checks for all configured MiMa projects against 4.2.0.
Also ran `git diff --check` and checked changed Scala lines for ASCII and the 100-column limit.
### Was this patch authored or co-authored using generative AI tooling?
Generated-by: OpenAI Codex (GPT-6)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60384][BUILD] Check binary compatibility against Spark 4.2.0 [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng commented on PR #59635:
URL: https://github.com/apache/spark/pull/59635#issuecomment-6339133718
**Merge Summary:**
- merged into master https://github.com/apache/spark/commit/9cb6933d10f663f30cb254081cb611343952ccfd
- merged into branch-4.x https://github.com/apache/spark/commit/269c2fcd0d8d8d1b6da11ec68f8ae115b19943c7
- merged into branch-4.3 https://github.com/apache/spark/commit/aa106af1cf6f2b5cbd4d4191d47de3ea54c9ce67
*Posted by `merge_spark_pr.py`*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-60384][BUILD] Check binary compatibility against Spark 4.2.0 [spark]
Posted by "zhengruifeng (via GitHub)" <gi...@apache.org>.
zhengruifeng closed pull request #59635: [SPARK-60384][BUILD] Check binary compatibility against Spark 4.2.0
URL: https://github.com/apache/spark/pull/59635
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org