You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/06/21 19:18:39 UTC
[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13707
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
thirdparty: fix build-if-necessary in tarballs
build-if-necessary, when run from a tarball, uses a build stamp file for
each build configuration to know whether it needs to re-run. However,
a normal build will build both 'common' and then 'tsan' configurations,
in that order. When we go back to check whether 'common' needs a
rebuild, we'll see the tsan build-stamp file and think it needs to be
rebuilt.
This fixes the check to exclude other build-stamp files.
Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
---
M thirdparty/build-if-necessary.sh
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/13707/1
--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh
File thirdparty/build-if-necessary.sh:
http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh@89
PS1, Line 89: grep -v '^\./\.build-stamp' |
: grep -v '^\.$' |
> This is functional, I suppose that could be done in a follow up. We use thi
SGTM
--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 21:16:44 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13707 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
thirdparty: fix build-if-necessary in tarballs
build-if-necessary, when run from a tarball, uses a build stamp file for
each build configuration to know whether it needs to re-run. However,
a normal build will build both 'common' and then 'tsan' configurations,
in that order. When we go back to check whether 'common' needs a
rebuild, we'll see the tsan build-stamp file and think it needs to be
rebuilt.
This fixes the check to exclude other build-stamp files.
Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Reviewed-on: http://gerrit.cloudera.org:8080/13707
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M thirdparty/build-if-necessary.sh
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh
File thirdparty/build-if-necessary.sh:
http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh@89
PS1, Line 89: grep -v '^\./\.build-stamp' |
: grep -v '^\.$' |
maybe, use find's notation of '-not'?
find . -cnwer $STAMP_FILE -not -name '.build-stamp' -not -name '.'
--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 20:45:11 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh
File thirdparty/build-if-necessary.sh:
http://gerrit.cloudera.org:8080/#/c/13707/1/thirdparty/build-if-necessary.sh@89
PS1, Line 89: grep -v '^\./\.build-stamp' |
: grep -v '^\.$' |
> maybe, use find's notation of '-not'?
This is functional, I suppose that could be done in a follow up. We use this style elsewhere in Kudu (see verify_jars.pl).
--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 20:51:30 +0000
Gerrit-HasComments: Yes
[kudu-CR](branch-1.10.x) thirdparty: fix build-if-necessary in tarballs
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13707 )
Change subject: thirdparty: fix build-if-necessary in tarballs
......................................................................
Patch Set 1: Code-Review+2
+2 since this is a backport. May want to address Alexey's feedback on master?
--
To view, visit http://gerrit.cloudera.org:8080/13707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.10.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifc600d065362e902f4f768080e1f91c90b9f0594
Gerrit-Change-Number: 13707
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 20:51:09 +0000
Gerrit-HasComments: No