You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by ro...@apache.org on 2019/06/26 09:56:18 UTC
[lucene-solr] 02/02: LUCENE-8811: Remove deprecated BooleanQuery
maxCount methods
This is an automated email from the ASF dual-hosted git repository.
romseygeek pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/lucene-solr.git
commit 6751c072ab5a7b28a13d0e639a2fbe08e13f02a5
Author: Alan Woodward <ro...@apache.org>
AuthorDate: Wed Jun 26 10:28:22 2019 +0100
LUCENE-8811: Remove deprecated BooleanQuery maxCount methods
---
lucene/CHANGES.txt | 3 +++
.../org/apache/lucene/search/BooleanQuery.java | 28 ----------------------
.../search/intervals/MultiTermIntervalsSource.java | 6 ++---
3 files changed, 6 insertions(+), 31 deletions(-)
diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 2dbb0ac..2446566 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -22,6 +22,9 @@ API Changes
byte[] that stores the UTF-8 bytes of the stored string.
(Namgyu Kim via Adrien Grand)
+* LUCENE-8811: Deprecated BooleanQuery#setMaxClauseCount() and getMaxClauseCount
+ have been removed (Atri Sharma, Adrien Grand, Alan Woodward)
+
Bug fixes
* LUCENE-8663: NRTCachingDirectory.slowFileExists may open a file while
diff --git a/lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java b/lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java
index 30983e0..60348fa 100644
--- a/lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java
+++ b/lucene/core/src/java/org/apache/lucene/search/BooleanQuery.java
@@ -41,34 +41,6 @@ import org.apache.lucene.search.BooleanClause.Occur;
*/
public class BooleanQuery extends Query implements Iterable<BooleanClause> {
- /** Thrown when an attempt is made to add more than {@link
- * #getMaxClauseCount()} clauses. This typically happens if
- * a PrefixQuery, FuzzyQuery, WildcardQuery, or TermRangeQuery
- * is expanded to many terms during search.
- * @deprecated use {@link IndexSearcher.TooManyClauses}
- */
- @Deprecated
- public static class TooManyClauses extends IndexSearcher.TooManyClauses { }
-
- /** Return the maximum number of clauses permitted, 1024 by default.
- * Attempts to add more than the permitted number of clauses cause {@link
- * TooManyClauses} to be thrown.
- * @see IndexSearcher#setMaxClauseCount(int)
- * @deprecated use {@link IndexSearcher#getMaxClauseCount()}
- */
- @Deprecated
- public static int getMaxClauseCount() { return IndexSearcher.getMaxClauseCount(); }
-
- /**
- * Set the maximum number of clauses permitted per BooleanQuery.
- * Default value is 1024.
- * @deprecated use {@link IndexSearcher#setMaxClauseCount(int)}
- */
- @Deprecated
- public static void setMaxClauseCount(int maxClauseCount) {
- IndexSearcher.setMaxClauseCount(maxClauseCount);
- }
-
/** A builder for boolean queries. */
public static class Builder {
diff --git a/lucene/sandbox/src/java/org/apache/lucene/search/intervals/MultiTermIntervalsSource.java b/lucene/sandbox/src/java/org/apache/lucene/search/intervals/MultiTermIntervalsSource.java
index 9c9b5f9..0be0168 100644
--- a/lucene/sandbox/src/java/org/apache/lucene/search/intervals/MultiTermIntervalsSource.java
+++ b/lucene/sandbox/src/java/org/apache/lucene/search/intervals/MultiTermIntervalsSource.java
@@ -27,7 +27,7 @@ import java.util.Objects;
import org.apache.lucene.index.LeafReaderContext;
import org.apache.lucene.index.Terms;
import org.apache.lucene.index.TermsEnum;
-import org.apache.lucene.search.BooleanQuery;
+import org.apache.lucene.search.IndexSearcher;
import org.apache.lucene.search.MatchesIterator;
import org.apache.lucene.search.MatchesUtils;
import org.apache.lucene.search.QueryVisitor;
@@ -42,9 +42,9 @@ class MultiTermIntervalsSource extends IntervalsSource {
MultiTermIntervalsSource(CompiledAutomaton automaton, int maxExpansions, String pattern) {
this.automaton = automaton;
- if (maxExpansions > BooleanQuery.getMaxClauseCount()) {
+ if (maxExpansions > IndexSearcher.getMaxClauseCount()) {
throw new IllegalArgumentException("maxExpansions [" + maxExpansions
- + "] cannot be greater than BooleanQuery.getMaxClauseCount [" + BooleanQuery.getMaxClauseCount() + "]");
+ + "] cannot be greater than BooleanQuery.getMaxClauseCount [" + IndexSearcher.getMaxClauseCount() + "]");
}
this.maxExpansions = maxExpansions;
this.pattern = pattern;