You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/08/12 05:56:33 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6636: ui: reset disksize param on offering change in scale vm
shwstppr opened a new pull request, #6636:
URL: https://github.com/apache/cloudstack/pull/6636
### Description
Fixes #6627
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6636: ui: reset disksize param on offering change in scale vm
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6636:
URL: https://github.com/apache/cloudstack/pull/6636#issuecomment-1212869965
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6636?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6636](https://codecov.io/gh/apache/cloudstack/pull/6636?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e00ced7) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/76f52af8f39dc5c397af6f5c3bebf3fc20b62a34?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (76f52af) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #6636 +/- ##
=========================================
Coverage 5.86% 5.86%
- Complexity 3918 3920 +2
=========================================
Files 2451 2451
Lines 242256 242256
Branches 37907 37907
=========================================
+ Hits 14207 14211 +4
+ Misses 226479 226475 -4
Partials 1570 1570
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6636?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/cloudstack/syslog/AlertsSyslogAppender.java](https://codecov.io/gh/apache/cloudstack/pull/6636/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hbGVydC1oYW5kbGVycy9zeXNsb2ctYWxlcnRzL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3N5c2xvZy9BbGVydHNTeXNsb2dBcHBlbmRlci5qYXZh) | `58.75% <0.00%> (+2.25%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] atmaniak commented on pull request #6636: ui: reset disksize param on offering change in scale vm
Posted by GitBox <gi...@apache.org>.
atmaniak commented on PR #6636:
URL: https://github.com/apache/cloudstack/pull/6636#issuecomment-1258002452
The problem is still present on Cloudstack 4.17.1.0.
Sometime it works, sometines not, and i can't reproduce a test scenario where it always work or always fail :
'https://cs.pa.bso.cloud/client/api/?id=38a18b83-5583-4a8f-85a6-58ab45ec8c88&serviceofferingid=93fa5ed3-58e1-4d8d-9e34-573b1239215e&automigrate=true&command=scaleVirtualMachine&response=json
. The rootdisksize
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr merged pull request #6636: ui: reset disksize param on offering change in scale vm
Posted by GitBox <gi...@apache.org>.
shwstppr merged PR #6636:
URL: https://github.com/apache/cloudstack/pull/6636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6636: ui: reset disksize param on offering change in scale vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6636:
URL: https://github.com/apache/cloudstack/pull/6636#issuecomment-1212755525
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6636: ui: reset disksize param on offering change in scale vm
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6636:
URL: https://github.com/apache/cloudstack/pull/6636#issuecomment-1212758189
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6636 (SL-JID-2134)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6636: ui: reset disksize param on offering change in scale vm
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6636:
URL: https://github.com/apache/cloudstack/pull/6636#issuecomment-1212755217
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org