You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/05/08 07:18:18 UTC

[GitHub] [hbase] Apache9 commented on a change in pull request #1640: HBASE-24309 Avoid introducing log4j and slf4j-log4j dependencies for modules other than hbase-assembly

Apache9 commented on a change in pull request #1640:
URL: https://github.com/apache/hbase/pull/1640#discussion_r421985089



##########
File path: hbase-shaded/pom.xml
##########
@@ -51,15 +51,14 @@
       <dependency>
          <groupId>org.apache.hbase</groupId>
          <artifactId>hbase-resource-bundle</artifactId>
-         <version>${project.version}</version>
          <optional>true</optional>
       </dependency>
-      <!-- log4j has to be non-optional for Hadoop 2 atleast -->
+      <!-- put the log implementations to optional -->

Review comment:
       At least for hadoop 2.8+, they have already moved to slf4j.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org