You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Wei Zhou <w....@leaseweb.com> on 2013/02/21 12:26:10 UTC

Review Request: add password in response of RestoreVM

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

Review request for cloudstack.


Description
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review18386
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment38589>

    Can you put some log message here, since restore is already completed till this point and only password reset is left that user can do by resetting the password afterwards if it fails here.


- Harikrishna Patnala


On March 22, 2013, 4:42 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated March 22, 2013, 4:42 a.m.)
> 
> 
> Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Harikrishna Patnala <ha...@citrix.com>.

> On April 25, 2013, 8:55 a.m., Harikrishna Patnala wrote:
> > Ship It!

Not a right time to give comments but came across a difference when comparing with my patch on master. we need to load vm details "_vmDao.loadDetails(vm)" before getting the details "vm.getDetail("SSH.PublicKey")". since details are transient. 


- Harikrishna


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review19694
-----------------------------------------------------------


On April 2, 2013, 1:24 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated April 2, 2013, 1:24 p.m.)
> 
> 
> Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review19694
-----------------------------------------------------------

Ship it!


Ship It!

- Harikrishna Patnala


On April 2, 2013, 1:24 p.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated April 2, 2013, 1:24 p.m.)
> 
> 
> Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review21071
-----------------------------------------------------------


Commit a5723992a0eeea9fc383c656b0d61dfc9e541ff9 in branch refs/heads/4.0 from Wei Zhou <w....@leaseweb.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=a572399 ]

CLOUDSTACK-1325: add password in response of RestoreVM


- ASF Subversion and Git Services


On May 6, 2013, 5:12 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request 9539: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review26267
-----------------------------------------------------------


Commit 5aee73b1a59f02c7853892d13afc58ad01f40c88 in branch refs/heads/4.1 from Wei Zhou
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=5aee73b ]

CLOUDSTACK-1325: add password in response of RestoreVM
(cherry picked from commit a5723992a0eeea9fc383c656b0d61dfc9e541ff9)

Signed-off-by: Wei Zhou <w....@leaseweb.com>


- ASF Subversion and Git Services


On May 6, 2013, 5:12 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.
> 
> 
> Bugs: CLOUDSTACK-1325
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

RE: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Harikrishna Patnala <ha...@citrix.com>.
Chip, can you push this patch on 4.0.1, this patch is specific to 4.0.1.
I have already pushed the similar patch on master. 

Thankyou

________________________
From: Animesh Chaturvedi
Sent: Friday, May 10, 2013 4:49 AM
To: dev@cloudstack.apache.org; Prasanna Santhanam; Harikrishna Patnala; Abhinandan Prateek
Cc: Sateesh Chodapuneedi; cloudstack; Wei Zhou
Subject: RE: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Abhi following up on this can you review and apply

> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Sunday, May 05, 2013 10:13 PM
> To: Harikrishna Patnala; Abhinandan Prateek
> Cc: Sateesh Chodapuneedi; Prasanna Santhanam; cloudstack; Wei Zhou
> Subject: Re: Review Request: (CLOUDSTACK-1325) add password in response
> of RestoreVM
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
>
> (Updated May 6, 2013, 5:12 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.
>
>
> Changes
> -------
>
> This is the same as Hari's patch and was submitted much earlier. Abhi - can
> you please review and apply this?
>
>
> Description
> -------
>
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
>
> This patch add a new password in the response.
>
>
> This addresses bug CLOUDSTACK-1325.
>
>
> Diffs
> -----
>
>   api/src/com/cloud/vm/UserVmService.java 6635657
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8
>
> Diff: https://reviews.apache.org/r/9539/diff/
>
>
> Testing
> -------
>
> Testing manually ok.
>
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a3
> 08-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
>
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-
> 4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
>
>
> Thanks,
>
> Wei Zhou

RE: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Animesh Chaturvedi <an...@citrix.com>.
Abhi following up on this can you review and apply

> -----Original Message-----
> From: Prasanna Santhanam [mailto:noreply@reviews.apache.org] On Behalf
> Of Prasanna Santhanam
> Sent: Sunday, May 05, 2013 10:13 PM
> To: Harikrishna Patnala; Abhinandan Prateek
> Cc: Sateesh Chodapuneedi; Prasanna Santhanam; cloudstack; Wei Zhou
> Subject: Re: Review Request: (CLOUDSTACK-1325) add password in response
> of RestoreVM
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated May 6, 2013, 5:12 a.m.)
> 
> 
> Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.
> 
> 
> Changes
> -------
> 
> This is the same as Hari's patch and was submitted much earlier. Abhi - can
> you please review and apply this?
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a3
> 08-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-
> 4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

(Updated May 6, 2013, 5:12 a.m.)


Review request for cloudstack, Abhinandan Prateek and Harikrishna Patnala.


Changes
-------

This is the same as Hari's patch and was submitted much earlier. Abhi - can you please review and apply this?


Description
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325

This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

(Updated April 25, 2013, 10:18 a.m.)


Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.


Changes
-------

add "_vmDao.loadDetails(vm);". 

Harikrishna, Thanks a lot.


Description
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325

This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs (updated)
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

(Updated April 2, 2013, 1:24 p.m.)


Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.


Changes
-------

According to the comment from Harikrishna Patnala, change throwing CloudRuntimeException to debugging.


Description
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325

This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs (updated)
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Prasanna Santhanam <Pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

(Updated March 22, 2013, 4:42 a.m.)


Review request for cloudstack, Sateesh Chodapuneedi and Harikrishna Patnala.


Description
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325

This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

(Updated Feb. 21, 2013, 1:11 p.m.)


Review request for cloudstack and Sateesh Chodapuneedi.


Changes
-------

according to the comments from Sateesh Chodapuneedi, I moved some codes to a seperate function.


Description
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325

This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs (updated)
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Sateesh Chodapuneedi <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/#review16841
-----------------------------------------------------------



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35763>

    Need to fix tab spaces here



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35765>

    There is good amount of common code in this snippet and resetPassword method in UserVmManagerImpl. Can you see if it is something to move into separate function.



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35762>

    Need to fix tab spaces here



server/src/com/cloud/vm/UserVmManagerImpl.java
<https://reviews.apache.org/r/9539/#comment35764>

    Need to fix trailing white spaces here


- Sateesh Chodapuneedi


On Feb. 21, 2013, 11:29 a.m., Wei Zhou wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9539/
> -----------------------------------------------------------
> 
> (Updated Feb. 21, 2013, 11:29 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Description
> -------
> 
> In 4.0.1, There is no password field in the respone of RestoreVM.
> Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325
> 
> This patch add a new password in the response.
> 
> 
> This addresses bug CLOUDSTACK-1325.
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/vm/UserVmService.java 6635657 
>   server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 
> 
> Diff: https://reviews.apache.org/r/9539/diff/
> 
> 
> Testing
> -------
> 
> Testing manually ok.
> 
> command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
>  public $jobid =>
>  string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"
> 
> command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
>  public $password =>
>  string(9) "mD5qkzmdk"
> 
> 
> Thanks,
> 
> Wei Zhou
> 
>

Re: Review Request: (CLOUDSTACK-1325) add password in response of RestoreVM

Posted by Wei Zhou <w....@leaseweb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9539/
-----------------------------------------------------------

(Updated Feb. 21, 2013, 11:29 a.m.)


Review request for cloudstack.


Summary (updated)
-----------------

(CLOUDSTACK-1325) add password in response of RestoreVM


Description (updated)
-------

In 4.0.1, There is no password field in the respone of RestoreVM.
Please see https://issues.apache.org/jira/browse/CLOUDSTACK-1325

This patch add a new password in the response.


This addresses bug CLOUDSTACK-1325.


Diffs
-----

  api/src/com/cloud/vm/UserVmService.java 6635657 
  server/src/com/cloud/vm/UserVmManagerImpl.java dbcbeb8 

Diff: https://reviews.apache.org/r/9539/diff/


Testing
-------

Testing manually ok.

command=restoreVirtualMachine&response=json&virtualmachineid=1a53a308-c870-452a-9eff-23975919286b
 public $jobid =>
 string(36) "7e855ed2-b5ab-4449-a163-5c1af62019ab"

command=queryAsyncJobResult&response=json&jobid=7e855ed2-b5ab-4449-a163-5c1af62019ab
 public $password =>
 string(9) "mD5qkzmdk"


Thanks,

Wei Zhou