You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@streampark.apache.org by GitBox <gi...@apache.org> on 2022/12/29 07:14:34 UTC

[GitHub] [incubator-streampark] wolfboys opened a new pull request, #2204: [Improve] cleanup duplicate licenses

wolfboys opened a new pull request, #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204

   [Improve] cleanup duplicate licenses


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] WillemJiang commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367779556

   We don't need to ship the Apache license in the license directory as they are the same.  Please clean up the third-party project licenses if they are Apache License V2.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367781157

   > ASM is released under the following 3-Clause BSD License: Please move the asm license from 2-Clause BSD License to 3-Clause BSD.
   
   done.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367781588

   > We don't need to ship the Apache license in the license directory as they are the same. Please clean up the third-party project licenses if they are Apache License V2.
   
   thanks for your review. i will fix it quickly


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] WillemJiang commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367778455

   ASM is released under the following 3-Clause BSD License:
   Please move the asm license from 2-Clause BSD License to 3-Clause BSD.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367778071

   > Please keep the file 'dist-material/release-docs/licenses/license-asm-asm.txt'， it‘s empty now. BTW, how do you store the front-end license in the binary release kit?
   
   
   thanks for your review.
   
   added license-asm-asm.txt file.
   front-end license: https://github.com/apache/incubator-streampark/tree/dev/dist-material/release-docs/licenses/front-end
   
   please review it again if you have free time. thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys merged pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys merged PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] WillemJiang commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1376681119

   As the License file is not a pure Apache License， it's better to provide the Apache License link in the below section.
   
   ![image](https://user-images.githubusercontent.com/219644/211455729-08bedabf-1a38-42d0-8781-0b1fa2aa1395.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367798974

   > We don't need to ship the Apache license in the license directory as they are the same. Please clean up the third-party project licenses if they are Apache License V2.
   
   thanks for your review. 
   all done,  third-party project Apache V2 License file removed. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] WillemJiang commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
WillemJiang commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367743501

   Please keep the file 'dist-material/release-docs/licenses/license-asm-asm.txt'， it‘s empty now.
   BTW, how do you store the front-end license in the binary release kit?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367845044

   cc @WillemJiang thanks for your review. happy new year! 🎈   please review it again if you have free time. thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] wolfboys commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
wolfboys commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1367119374

   cc @WillemJiang PTAL, if you have free time, thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-streampark] tisonkun commented on pull request #2204: [Improve] cleanup duplicate licenses

Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #2204:
URL: https://github.com/apache/incubator-streampark/pull/2204#issuecomment-1376749391

   @WillemJiang the content of Apache License is already present in the beginning of that file.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@streampark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org