You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/07/31 21:10:03 UTC

[GitHub] [incubator-tvm] kevinthesun edited a comment on pull request #6066: [TIR][Transform] HoistIfThenElse added

kevinthesun edited a comment on pull request #6066:
URL: https://github.com/apache/incubator-tvm/pull/6066#issuecomment-667357815


   One thing I think it is good to have in this PR is to get some benchmark data. IMO this pass is especially valuable when tackling dynamic kernels in GPU which introduces a lot of branchings. It's great to see how much performance improvement we can have. For CPU, we need to make sure this pass doesn't introduce regression for some common workloads, such as resnet.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org