You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@shindig.apache.org by li...@apache.org on 2010/09/16 13:34:23 UTC

svn commit: r997695 - /shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java

Author: lindner
Date: Thu Sep 16 11:34:22 2010
New Revision: 997695

URL: http://svn.apache.org/viewvc?rev=997695&view=rev
Log:
SHINDIG-1374 | Last final findbugs issue in java/gadgets

Modified:
    shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java

Modified: shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java
URL: http://svn.apache.org/viewvc/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java?rev=997695&r1=997694&r2=997695&view=diff
==============================================================================
--- shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java (original)
+++ shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/uri/UriUtils.java Thu Sep 16 11:34:22 2010
@@ -262,14 +262,17 @@ public final class UriUtils {
     String contentTypeWithoutCharset = content;
     String[] parts = StringUtils.split(content, ';');
     if (parts.length >= 2) {
-      contentTypeWithoutCharset = parts[0];
+      StringBuilder contentTypeWithoutCharsetBuilder = new StringBuilder(parts.length);
+      contentTypeWithoutCharsetBuilder.append(parts[0]);
+
       for (int i = 1; i < parts.length; i++) {
         String parameterAndValue = parts[i].trim().toLowerCase();
         String[] splits = StringUtils.split(parameterAndValue, '=');
         if (splits.length > 0 && !splits[0].trim().equals(CHARSET)) {
-          contentTypeWithoutCharset += ";" + parts[i];
+          contentTypeWithoutCharsetBuilder.append(';').append(parts[i]);
         }
       }
+      contentTypeWithoutCharset = contentTypeWithoutCharsetBuilder.toString();
     }
 
     return contentTypeWithoutCharset;