You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/02/18 21:19:02 UTC
[GitHub] [tvm] cconvey opened a new pull request #10320: Fix wrong terminology in `tvmc` source
cconvey opened a new pull request #10320:
URL: https://github.com/apache/tvm/pull/10320
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @ them in the pull request thread.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
cconvey commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1045203233
cc: @areusch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero edited a comment on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
gromero edited a comment on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1050807195
@leandron It seems the CI failed due to an unrelated issue (something related to Ethos-U55 AOT tests, but I can't follow exactly what) Have you ever seen this error before? Is it known to be a flaky test? hmm just realized that @areusch seems to wresting with some ethos-u55 test in here too: https://github.com/apache/tvm/pull/10283#issuecomment-1050695312
@cconvey The CI failed but I can't see how it can be related to your change, hence while we try to understand it better could you please re-trigger the CI? (you can, for example, just do `git --amend --no-edit` to change the commit hash and `push --force` again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1050807195
@leandron It seems the CI failed due to an unrelated issue (something related to Ethos-U55 AOT tests, but I can't follow exactly what) Have you ever seen this error before? Is it known to be a flaky test? hmm just realized that @areusch seems to wresting with some ethos-u55 test in here too: https://github.com/apache/tvm/pull/10283#issuecomment-1050695312
@cconvey The CI failed but I can't see how it can be related to your change, hence while we try to understand it better could you please re-trigger the C please? (you can, for example, just do `git --amend --no-edit` to change the commit hash and `push --force` again).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] areusch commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
areusch commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1054447509
@cconvey yeah i think these are the flaky ethos-u tests, can you push again? I think #10020 but unsure if there is a better bug for this particular flake
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1047920985
cc @leandron
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
cconvey commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1047887273
cc: @jwfromm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey edited a comment on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
cconvey edited a comment on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1048072119
Thanks @gromero ! Would you mind clarifying part of your comment?
> ... we can now pass a `Runtime()` object and a `Executor()` object
When you write `Runtime()` and `Executor()`, are you referring to _actual_ C++/Python functions or class names? Or should I read that as pseudocode that wouldn't be literally valid in TVM?
My impression was that TVM doesn't actually use common base classes, etc. to ensure a common interface across the different executor implementations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] gromero commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
gromero commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1049361537
> Thanks @gromero ! Would you mind clarifying part of your comment?
>
> > ... we can now pass a `Runtime()` object and a `Executor()` object
>
> When you write `Runtime()` and `Executor()`, are you referring to _actual_ C++/Python functions or class names? Or should I read that as pseudocode that wouldn't be literally valid in TVM?
@cconvey I had the `Runtime` and `Executor` Python classes in mind yep, the ones found in the source below, which are actually mapped to the C++ code found in `./src`, via the CFFI:
https://github.com/apache/tvm/blob/main/python/tvm/relay/backend/executor.py#L27
https://github.com/apache/tvm/blob/main/python/tvm/relay/backend/runtime.py#L27
and used, for instance, like in:
https://github.com/apache/tvm/blob/main/tests/micro/zephyr/test_zephyr_aot.py#L69-L72
But more broadly I was just saying that if I'm not mistaken in the past the concepts of runtime and executor were not as clear as they are now, back when there wasn't the even the AOT executor and before the discussions/changes around:
https://github.com/apache/tvm/pull/9352
... and I think your patch is fixing what looks a reminiscent code of that period.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] masahi merged pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
masahi merged pull request #10320:
URL: https://github.com/apache/tvm/pull/10320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
cconvey commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1048072119
Thanks @gromero ! Would you mind clarifying part of your comment?
> ... we can now pass a `Runtime()` object and a `Executor()` object
When you write `Runtime()` and `Executor()`, are you referring to _actual_ C++/Python functions or class constructors? Or should I read that as pseudocode that wouldn't be literally valid in TVM?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
cconvey commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1050042758
Thanks @gromero for all the background information, I find it very helpful! AFAIK I've addressed your feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cconvey commented on pull request #10320: Fix wrong terminology in `tvmc` source
Posted by GitBox <gi...@apache.org>.
cconvey commented on pull request #10320:
URL: https://github.com/apache/tvm/pull/10320#issuecomment-1076709486
@tqchen Ready for merge
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org