You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "michaeljmarshall (via GitHub)" <gi...@apache.org> on 2023/06/01 03:59:17 UTC
[GitHub] [pulsar] michaeljmarshall opened a new pull request, #20453: [feat] PIP-273: Enable hostname verification by default
michaeljmarshall opened a new pull request, #20453:
URL: https://github.com/apache/pulsar/pull/20453
### Motivation
This is a PIP to enable hostname verification by default. The PR contents have the motivation.
### Documentation
- [x] `doc-not-needed`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] asafm commented on pull request #20453: [feat] PIP-273: Enable hostname verification by default
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-1616448431
Can we change the PR title?
Per the [PIP instructions](https://github.com/apache/pulsar/blob/master/pip/README.md):
> Create GitHub Pull request (PR). The PR title should be [pip][design] PIP-xxx: {title}, where the xxx match the number given in previous step (file-name). Replace {title} with a short title to your proposal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] asafm commented on pull request #20453: [feat] PIP-273: Enable hostname verification by default
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-1571604951
First one to try out the new process 💯 @michaeljmarshall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] asafm commented on pull request #20453: [feat] PIP-273: Enable hostname verification by default
Posted by "asafm (via GitHub)" <gi...@apache.org>.
asafm commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-1571622020
Super readable and clear 💯. I wish all PIPs were like it.
Looks reasonable to me, although I lack any real experience with TLS and its matching validation, so can't contribute there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] michaeljmarshall commented on pull request #20453: [pip][design] PIP-273: Enable hostname verification by default
Posted by "michaeljmarshall (via GitHub)" <gi...@apache.org>.
michaeljmarshall commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-1624641137
> Can we change the PR title? Per the [PIP instructions](https://github.com/apache/pulsar/blob/master/pip/README.md):
>
> > Create GitHub Pull request (PR). The PR title should be [pip][design] PIP-xxx: {title}, where the xxx match the number given in previous step (file-name). Replace {title} with a short title to your proposal.
@asafm - done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][pip] PIP-273: Enable hostname verification by default [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-6381301980
Hi @michaeljmarshall, PIP-273 passed its vote, so I've brought this up to date so it can be merged as part of the open-PR backlog pass (https://lists.apache.org/thread/cgy7w0qgnq8s7j0ykyzgrn3hj4nb67wf). I merged master and renamed the files to the current `pip/` convention (`pip/pip-273.md`, image under `pip/images/pip-273/`), added it to `000-INDEX.md`, and filled in the dev@ discussion and vote links. The defaults themselves were switched on by PIP-478 (#26282), which the General Notes now mention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20453: [pip][design] PIP-273: Enable hostname verification by default
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-1700225841
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #20453: [feat] PIP-273: Enable hostname verification by default
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #20453:
URL: https://github.com/apache/pulsar/pull/20453#issuecomment-1616277485
The pr had no activity for 30 days, mark with Stale label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [improve][pip] PIP-273: Enable hostname verification by default [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #20453:
URL: https://github.com/apache/pulsar/pull/20453
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org