You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Johan Oskarsson (JIRA)" <ji...@apache.org> on 2009/02/12 12:37:59 UTC

[jira] Created: (HIVE-286) testCliDriver_udf7 fails

testCliDriver_udf7 fails
------------------------

                 Key: HIVE-286
                 URL: https://issues.apache.org/jira/browse/HIVE-286
             Project: Hadoop Hive
          Issue Type: Bug
          Components: Query Processor
         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
            Reporter: Johan Oskarsson
            Priority: Blocker
             Fix For: 0.2.0


The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-286) testCliDriver_udf7 fails

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680033#action_12680033 ] 

Zheng Shao commented on HIVE-286:
---------------------------------

Thanks for the quick commit Johan!
Can you close the issue and put the new line in CHANGES.txt in the "Release note" section?


> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Assignee: Zheng Shao
>            Priority: Blocker
>             Fix For: 0.3.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-286) testCliDriver_udf7 fails

Posted by "Ashish Thusoo (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12673098#action_12673098 ] 

Ashish Thusoo commented on HIVE-286:
------------------------------------

Seems to be related to precision?

diff -a -I \(file:\)\|\(/tmp/.*\) /home/hudson/hudson-slave/workspace/Hive-trunk-h0.19/hive/build/ql/test/logs/clientpositive/udf7.q.out /home/hudson/hudson-slave/workspace/Hive-trunk-h0.19/hive/ql/src/test/results/clientpositive/udf7.q.out
77c77
< 1.0986122886681098	NULL	NULL	1.0986122886681098	NULL	NULL	1.5849625007211563	NULL	NULL	0.47712125471966244	NULL	NULL	1.5849625007211563	NULL	NULL	NULL	-1.0	7.38905609893065	8.0	8.0	0.125	8.0	2.0	NaN	1.0
---
> 1.0986122886681096	NULL	NULL	1.0986122886681096	NULL	NULL	1.584962500721156	NULL	NULL	0.4771212547196623	NULL	NULL	1.584962500721156	NULL	NULL	NULL	-1.0	7.38905609893065	8.0	8.0	0.125	8.0	2.0	NaN	1.0
Exception: Client execution results dailed with error code = 1


> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Priority: Blocker
>             Fix For: 0.2.0
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-286) testCliDriver_udf7 fails

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Oskarsson updated HIVE-286:
---------------------------------

      Resolution: Fixed
    Release Note: HIVE-286. Use round(xxx,12) to make sure there is no precision matching problem in testCliDriver_udf7. (zshao via johan)   
    Hadoop Flags: [Reviewed]
          Status: Resolved  (was: Patch Available)

Committed revision 751398. Thanks Zheng!

> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Assignee: Zheng Shao
>            Priority: Blocker
>             Fix For: 0.3.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (HIVE-286) testCliDriver_udf7 fails

Posted by "Johan Oskarsson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Oskarsson closed HIVE-286.
--------------------------------


The release note is already there. So the Hive way is to close the issue rather then resolve it? Closing it now as requested.

> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Assignee: Zheng Shao
>            Priority: Blocker
>             Fix For: 0.3.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-286) testCliDriver_udf7 fails

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680101#action_12680101 ] 

Zheng Shao commented on HIVE-286:
---------------------------------

Hi Johan, "Resolved" is good enough. Somehow I didn't see the issue was resolved last time. The next time you just need to resolve the issue as usual.



> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Assignee: Zheng Shao
>            Priority: Blocker
>             Fix For: 0.3.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-286) testCliDriver_udf7 fails

Posted by "Prasad Chakka (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677857#action_12677857 ] 

Prasad Chakka commented on HIVE-286:
------------------------------------

this change might break existing code which may assume large precision. we should make it configurable until we have proper decimal type.

> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: hive-286.1.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (HIVE-286) testCliDriver_udf7 fails

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao reassigned HIVE-286:
-------------------------------

    Assignee: Zheng Shao

> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Assignee: Zheng Shao
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-286) testCliDriver_udf7 fails

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-286:
----------------------------

    Fix Version/s:     (was: 0.2.0)
                   0.3.0
           Status: Patch Available  (was: Open)

> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Assignee: Zheng Shao
>            Priority: Blocker
>             Fix For: 0.3.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-286) testCliDriver_udf7 fails

Posted by "Raghotham Murthy (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Raghotham Murthy updated HIVE-286:
----------------------------------

    Attachment: hive-286.1.patch

getting tired of seeing the build errors because of this. Cant we just use DecimalFormat and print out 4 digits after the decimal (similar to mysql)? We can later add a DECIMAL type which supports user specified precision and scale. I have attached changes to LazySimpleSerDe. 

> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: hive-286.1.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (HIVE-286) testCliDriver_udf7 fails

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Zheng Shao updated HIVE-286:
----------------------------

    Attachment: HIVE-286.2.patch

Use round(xxx,12) to make sure there is no precision matching problem in testing.


> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: hive-286.1.patch, HIVE-286.2.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (HIVE-286) testCliDriver_udf7 fails

Posted by "Zheng Shao (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677863#action_12677863 ] 

Zheng Shao commented on HIVE-286:
---------------------------------

Agree. We should not sacrifice the precision in default.

The MySQL function closest to sprintf is http://dev.mysql.com/doc/refman/5.0/en/string-functions.html#function_format

Let's add that format function instead, and use it in the test cases to make sure it does not fail again.


> testCliDriver_udf7 fails
> ------------------------
>
>                 Key: HIVE-286
>                 URL: https://issues.apache.org/jira/browse/HIVE-286
>             Project: Hadoop Hive
>          Issue Type: Bug
>          Components: Query Processor
>         Environment: Ubuntu, Java6, Hadoop 0.17, 0.18 and 0.19
>            Reporter: Johan Oskarsson
>            Priority: Blocker
>             Fix For: 0.2.0
>
>         Attachments: hive-286.1.patch
>
>
> The org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_udf7 test fails.
> See this url for more information: http://hudson.zones.apache.org/hudson/job/Hive-trunk-h0.19/lastBuild/testReport/org.apache.hadoop.hive.cli/TestCliDriver/testCliDriver_udf7/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.